Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer install the Jupyter extension by default #20218

Merged
merged 10 commits into from
Mar 29, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ The Python extension does offer [some support](https://github.com/microsoft/vsco

## Installed extensions

The Python extension will automatically install the [Pylance](https://marketplace.visualstudio.com/items?itemName=ms-python.vscode-pylance), [Jupyter](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter) and [isort](https://marketplace.visualstudio.com/items?itemName=ms-python.isort) extensions to give you the best experience when working with Python files and Jupyter notebooks. However, Pylance is an optional dependency, meaning the Python extension will remain fully functional if it fails to be installed. You can also [uninstall](https://code.visualstudio.com/docs/editor/extension-marketplace#_uninstall-an-extension) it at the expense of some features if you’re using a different language server.
The Python extension will automatically install the [Pylance](https://marketplace.visualstudio.com/items?itemName=ms-python.vscode-pylance) and [isort](https://marketplace.visualstudio.com/items?itemName=ms-python.isort) extensions to give you the best experience when working with Python files. However, they are both optional dependencies, meaning the Python extension will remain fully functional if either one fails to be installed. You can [uninstall](https://code.visualstudio.com/docs/editor/extension-marketplace#_uninstall-an-extension) Pylance at the expense of some features if you’re using a different language server.
luabud marked this conversation as resolved.
Show resolved Hide resolved

Extensions installed through the marketplace are subject to the [Marketplace Terms of Use](https://cdn.vsassets.io/v/M146_20190123.39/_content/Microsoft-Visual-Studio-Marketplace-Terms-of-Use.pdf).

Expand Down Expand Up @@ -37,7 +37,9 @@ Extensions installed through the marketplace are subject to the [Marketplace Ter

## Jupyter Notebook quick start

The Python extension and the [Jupyter extension](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter) work together to give you a great Notebook experience in VS Code.
The Python extension no longer offers support for Jupyter notebooks out of the box. However, it works with the [Jupyter extension](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter) to provide you a great Python notebook experience in VS Code.

- Install the [Jupyter extension](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter).

- Open or create a Jupyter Notebook file (.ipynb) and start coding in our Notebook Editor!

Expand Down
3 changes: 0 additions & 3 deletions build/license-header.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
PLEASE NOTE: This is the license for the Python extension for Visual Studio Code. The Python extension automatically installs other extensions as optional dependencies, which can be uninstalled at any time. These extensions have separate licenses:

- The Jupyter extension is released under an MIT License:
https://marketplace.visualstudio.com/items/ms-toolsai.jupyter/license

- The isort extension is released under an MIT License:
https://marketplace.visualstudio.com/items/ms-python.isort/license

Expand Down
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ async function addExtensionPackDependencies() {
// extension dependencies need not be installed during development
const packageJsonContents = await fsExtra.readFile('package.json', 'utf-8');
const packageJson = JSON.parse(packageJsonContents);
packageJson.extensionPack = ['ms-toolsai.jupyter', 'ms-python.vscode-pylance', 'ms-python.isort'].concat(
packageJson.extensionPack = ['ms-python.vscode-pylance', 'ms-python.isort'].concat(
packageJson.extensionPack ? packageJson.extensionPack : [],
);
luabud marked this conversation as resolved.
Show resolved Hide resolved
luabud marked this conversation as resolved.
Show resolved Hide resolved
await fsExtra.writeFile('package.json', JSON.stringify(packageJson, null, 4), 'utf-8');
Expand Down
8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "python",
"displayName": "Python",
"description": "IntelliSense (Pylance), Linting, Debugging (multi-threaded, remote), Jupyter Notebooks, code formatting, refactoring, unit tests, and more.",
"description": "IntelliSense (Pylance), Linting, Debugging (multi-threaded, remote), code formatting, refactoring, unit tests, and more.",
"version": "2022.19.0-dev",
"featureFlags": {
"usingNewInterpreterStorage": true
Expand Down Expand Up @@ -2002,5 +2002,9 @@
"id": "f1f59ae4-9318-4f3c-a9b5-81b2eaa5f8a5",
"publisherDisplayName": "Microsoft",
"publisherId": "998b010b-e2af-44a5-a6cd-0b5fd3b9b6f8"
}
},
"extensionPack": [
"ms-python.vscode-pylance",
"ms-python.isort"
]
karrtikr marked this conversation as resolved.
Show resolved Hide resolved
}