Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all typescript errors when compiled in strict mode #3 #4419

Merged
merged 7 commits into from
Mar 1, 2019

Conversation

karrtikr
Copy link

For #611 part 3

@karrtikr karrtikr added the no-changelog No news entry required label Feb 15, 2019
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #4419 into master will increase coverage by 20%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #4419     +/-   ##
========================================
+ Coverage      58%     78%    +20%     
========================================
  Files         369     445     +76     
  Lines       15946   21071   +5125     
  Branches     2507    3423    +916     
========================================
+ Hits         9134   16241   +7107     
+ Misses       6190    4824   -1366     
+ Partials      622       6    -616
Flag Coverage Δ
#Linux 65% <80%> (?)
#Windows 66% <80%> (?)
#macOS 65% <80%> (?)

Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine, it's not changing any of the logic from the original versions. However, the use of null instead of undefined seems suspect. Please have a quick chat with @DonJayamanne on the places where I make mention of this before merging.

@d3r3kk d3r3kk closed this Mar 1, 2019
@d3r3kk
Copy link

d3r3kk commented Mar 1, 2019

CI timeout/matplotlib problem (should be fixed now).

@d3r3kk d3r3kk reopened this Mar 1, 2019
@karrtikr karrtikr closed this Mar 1, 2019
@karrtikr karrtikr reopened this Mar 1, 2019
@d3r3kk d3r3kk merged commit f0c17fe into microsoft:master Mar 1, 2019
@karrtikr karrtikr deleted the errors3 branch March 1, 2019 21:21
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants