-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all typescript errors when compiled in strict mode #3 #4419
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4419 +/- ##
========================================
+ Coverage 58% 78% +20%
========================================
Files 369 445 +76
Lines 15946 21071 +5125
Branches 2507 3423 +916
========================================
+ Hits 9134 16241 +7107
+ Misses 6190 4824 -1366
+ Partials 622 6 -616
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fine, it's not changing any of the logic from the original versions. However, the use of null
instead of undefined
seems suspect. Please have a quick chat with @DonJayamanne on the places where I make mention of this before merging.
Co-Authored-By: karrtikr <karraj@microsoft.com>
CI timeout/matplotlib problem (should be fixed now). |
For #611 part 3