Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing image/dockerfile/dockerComposeFile with definitions picker #2937

Closed
chrmarti opened this issue May 5, 2020 · 1 comment
Closed
Assignees
Labels
containers Issue in vscode-remote containers plan-item A plan item
Milestone

Comments

@chrmarti
Copy link
Contributor

chrmarti commented May 5, 2020

Ref microsoft/vscode#96925

@chrmarti chrmarti added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels May 5, 2020
@chrmarti chrmarti self-assigned this May 5, 2020
@chrmarti chrmarti added this to the May 2020 milestone May 5, 2020
@chrmarti
Copy link
Contributor Author

chrmarti commented May 7, 2020

@Chuxel FYI: The idea here is to copy from a definition parts of the devcontainer.json properties into the existing devcontainer.json and copy all other files (Dockerfile, docker-compose.yml) in full. I'll merge lists like extensions and objects like settings.

@chrmarti chrmarti added plan-item A plan item and removed feature-request Request for new features or functionality labels May 12, 2020
@chrmarti chrmarti changed the title Handle missing image/dockerfile/dockerComoposeFile with definitions picker Handle missing image/dockerfile/dockerComposeFile with definitions picker May 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers plan-item A plan item
Projects
None yet
Development

No branches or pull requests

1 participant