Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user-friendly info to --help #884

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

bandantonio
Copy link
Contributor

Resolves #769

Description

This PR adds basic user-friendly message as a description, which is expected to appear at every command passed with the --help flag. The current commander version (6.1.0) doesn't support certain commands that help adding this message properly (like only for the 'root' help), as well as other commands that potentially can be helpful in optimizing the current code and removing the parts that commander has implemented under-the-hood (like showing suggestions on errors).
So I would highly suggest creating an issue to proceed with migration to version 8.2.0 at least. And I would love to help you with that migration.

Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the whitespace changes. Also remove the huge non-user-friendly ASCII art.

@joaomoreno joaomoreno self-assigned this Aug 25, 2023
joaomoreno
joaomoreno previously approved these changes Aug 30, 2023
@joaomoreno joaomoreno enabled auto-merge (squash) August 30, 2023 09:45
@joaomoreno joaomoreno added this to the August 2023 milestone Aug 30, 2023
@joaomoreno joaomoreno merged commit 986df2b into microsoft:main Aug 30, 2023
15 checks passed
@bandantonio bandantonio deleted the user-welcome-message branch August 30, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print user friendly message when vsce is installed
3 participants