From b71ba9f10fa315fd924a80969e5a0cf67ff49c23 Mon Sep 17 00:00:00 2001 From: Vinicius A L Souza Date: Thu, 23 Jan 2025 16:36:26 -0300 Subject: [PATCH 1/3] Improves text by adding ":" to end of sentence to keep consistency --- ...erf]-PerformanceError-and-unresponsive-renderer-telemetry.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md b/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md index bea1279b33..654987e69b 100644 --- a/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md +++ b/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md @@ -1,6 +1,6 @@ ## Automatic renderer profiling -The renderer process is monitored for "hangs" and when those occur automatic profiling is started. It works as follows +The renderer process is monitored for "hangs" and when those occur automatic profiling is started. It works as follows: * after startup a performance baseline is computed (on fast machines this is fine-tuned to be roughly one frame at 64fps, 15ms) * when a [long task](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceLongTaskTiming) that is 10x of the baseline is reported, automatic renderer profiling is started (for 5secs) From f3d6ca523188a54ec34437c9eaff78271547426d Mon Sep 17 00:00:00 2001 From: Vinicius A L Souza Date: Thu, 23 Jan 2025 16:37:05 -0300 Subject: [PATCH 2/3] Fixes typo. Removes misplaced "the" from sentence --- ...erf]-PerformanceError-and-unresponsive-renderer-telemetry.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md b/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md index 654987e69b..e38f145da9 100644 --- a/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md +++ b/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md @@ -9,7 +9,7 @@ The renderer process is monitored for "hangs" and when those occur automatic pro #### Dealing with `PerfSampleError` error -As mentioned above, hangs are reported as normal- and error-telemetry. When the a certain error event is reported many times it shows up on our error triage page. The error shows a synthetic stacktrace which is the callstack that the profiler saw most often. The top is the slow function and the calls is how it was called. +As mentioned above, hangs are reported as normal- and error-telemetry. When a certain error event is reported many times it shows up on our error triage page. The error shows a synthetic stacktrace which is the callstack that the profiler saw most often. The top is the slow function and the calls is how it was called. If the error telemetry isn't sufficient you can dig into telemetry. Use the query below but make sure use the right version of VSCode and filter for the name of your function. _Note_ that only stable versions of VS Code yield usable results. That is because insiders generates too little data. The query will show how many machines were affected and what the average hang-time was. From 99496f9a634965dd6b4f0114fb5d2936608fe855 Mon Sep 17 00:00:00 2001 From: Vinicius A L Souza Date: Thu, 23 Jan 2025 16:37:33 -0300 Subject: [PATCH 3/3] Fixes typo. Adds missing "to" to sentence --- ...erf]-PerformanceError-and-unresponsive-renderer-telemetry.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md b/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md index e38f145da9..94c6b8e7cb 100644 --- a/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md +++ b/[dev-perf]-PerformanceError-and-unresponsive-renderer-telemetry.md @@ -11,7 +11,7 @@ The renderer process is monitored for "hangs" and when those occur automatic pro As mentioned above, hangs are reported as normal- and error-telemetry. When a certain error event is reported many times it shows up on our error triage page. The error shows a synthetic stacktrace which is the callstack that the profiler saw most often. The top is the slow function and the calls is how it was called. -If the error telemetry isn't sufficient you can dig into telemetry. Use the query below but make sure use the right version of VSCode and filter for the name of your function. _Note_ that only stable versions of VS Code yield usable results. That is because insiders generates too little data. The query will show how many machines were affected and what the average hang-time was. +If the error telemetry isn't sufficient you can dig into telemetry. Use the query below but make sure to use the right version of VSCode and filter for the name of your function. _Note_ that only stable versions of VS Code yield usable results. That is because insiders generates too little data. The query will show how many machines were affected and what the average hang-time was. ```js RawEventsVSCode