Skip to content

Commit

Permalink
don't show loader stats in perf view editor anymore
Browse files Browse the repository at this point in the history
  • Loading branch information
@jrieken
jrieken committed Dec 16, 2020
1 parent 25d6642 commit 2092016
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions src/vs/workbench/contrib/performance/browser/perfviewEditor.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ class PerfModelContentProvider implements ITextModelContentProvider {
md.blank();
this._addRawPerfMarks(md);
md.blank();
this._addLoaderStats(md, stats);
md.blank();
// this._addLoaderStats(md, stats);
// md.blank();
this._addCachedDataStats(md);

this._model.setValue(md.value);
Expand Down Expand Up @@ -238,20 +238,20 @@ class PerfModelContentProvider implements ITextModelContentProvider {
}
}

private _addLoaderStats(md: MarkdownBuilder, stats: LoaderStats): void {
md.heading(2, 'Loader Stats');
md.heading(3, 'Load AMD-module');
md.table(['Module', 'Duration'], stats.amdLoad);
md.blank();
md.heading(3, 'Load commonjs-module');
md.table(['Module', 'Duration'], stats.nodeRequire);
md.blank();
md.heading(3, 'Invoke AMD-module factory');
md.table(['Module', 'Duration'], stats.amdInvoke);
md.blank();
md.heading(3, 'Invoke commonjs-module');
md.table(['Module', 'Duration'], stats.nodeEval);
}
// private _addLoaderStats(md: MarkdownBuilder, stats: LoaderStats): void {
// md.heading(2, 'Loader Stats');
// md.heading(3, 'Load AMD-module');
// md.table(['Module', 'Duration'], stats.amdLoad);
// md.blank();
// md.heading(3, 'Load commonjs-module');
// md.table(['Module', 'Duration'], stats.nodeRequire);
// md.blank();
// md.heading(3, 'Invoke AMD-module factory');
// md.table(['Module', 'Duration'], stats.amdInvoke);
// md.blank();
// md.heading(3, 'Invoke commonjs-module');
// md.table(['Module', 'Duration'], stats.nodeEval);
// }

private _addCachedDataStats(md: MarkdownBuilder): void {

Expand Down

2 comments on commit 2092016

@bpasero
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, any reason?

@jrieken
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, for once this will disappear with ESM, second this makes issues really, really large (we often ask users to copy-paste the perf editor readings). On the console you can just type require.getStats and use the results for some custom processing

Please sign in to comment.