Remove old prompt from tasks service

Part of #119463
microsoft · Apr 22, 2021 · 29ade59 · 29ade59
1 parent 00e8e64
commit 29ade59
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 23 deletions.
diff --git a/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts b/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
@@ -30,7 +30,6 @@ import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storag
 import { IProgressService, IProgressOptions, ProgressLocation } from 'vs/platform/progress/common/progress';
 
 import { IOpenerService } from 'vs/platform/opener/common/opener';
-import { IHostService } from 'vs/workbench/services/host/browser/host';
 import { INotificationService } from 'vs/platform/notification/common/notification';
 import { IDialogService } from 'vs/platform/dialogs/common/dialogs';
 
@@ -248,7 +247,6 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
  @IStorageService private readonly storageService: IStorageService,
  @IProgressService private readonly progressService: IProgressService,
  @IOpenerService private readonly openerService: IOpenerService,
- @IHostService private readonly _hostService: IHostService,
  @IDialogService protected readonly dialogService: IDialogService,
  @INotificationService private readonly notificationService: INotificationService,
  @IContextKeyService protected readonly contextKeyService: IContextKeyService,
@@ -276,24 +274,8 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
  }
  let folderSetup = this.computeWorkspaceFolderSetup();
  if (this.executionEngine !== folderSetup[2]) {
- if (this._taskSystem && this._taskSystem.getActiveTasks().length > 0) {
- this.notificationService.prompt(
- Severity.Info,
- nls.localize(
- 'TaskSystem.noHotSwap',
- 'Changing the task execution engine with an active task running requires to reload the Window'
- ),
- [{
- label: nls.localize('reloadWindow', "Reload Window"),
- run: () => this._hostService.reload()
- }],
- { sticky: true }
- );
- return;
- } else {
- this.disposeTaskSystemListeners();
- this._taskSystem = undefined;
- }
+ this.disposeTaskSystemListeners();
+ this._taskSystem = undefined;
  }
  this.updateSetup(folderSetup);
  this.updateWorkspaceTasks();

diff --git a/src/vs/workbench/contrib/tasks/electron-browser/taskService.ts b/src/vs/workbench/contrib/tasks/electron-browser/taskService.ts
@@ -36,7 +36,6 @@ import { IConfigurationResolverService } from 'vs/workbench/services/configurati
 import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
 import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/common/environmentService';
 import { IExtensionService } from 'vs/workbench/services/extensions/common/extensions';
-import { IHostService } from 'vs/workbench/services/host/browser/host';
 import { ILifecycleService } from 'vs/workbench/services/lifecycle/common/lifecycle';
 import { IPanelService } from 'vs/workbench/services/panel/common/panelService';
 import { IPathService } from 'vs/workbench/services/path/common/pathService';
@@ -72,7 +71,6 @@ export class TaskService extends AbstractTaskService {
  @IStorageService storageService: IStorageService,
  @IProgressService progressService: IProgressService,
  @IOpenerService openerService: IOpenerService,
- @IHostService _hostService: IHostService,
  @IDialogService dialogService: IDialogService,
  @INotificationService notificationService: INotificationService,
  @IContextKeyService contextKeyService: IContextKeyService,
@@ -103,7 +101,6 @@ export class TaskService extends AbstractTaskService {
  storageService,
  progressService,
  openerService,
- _hostService,
  dialogService,
  notificationService,
  contextKeyService,