From 73f3a3e0769e19f0af369759ba55258c0c0b08a2 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Fri, 27 Sep 2024 07:15:20 -0700 Subject: [PATCH] Prevent terminal SI decorations showing under quick fixes Fixes #229872 --- .../contrib/terminalContrib/quickFix/browser/quickFixAddon.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts b/src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts index 2dd13565faf4d..c117ec175446a 100644 --- a/src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts +++ b/src/vs/workbench/contrib/terminalContrib/quickFix/browser/quickFixAddon.ts @@ -247,7 +247,7 @@ export class TerminalQuickFixAddon extends Disposable implements ITerminalAddon, if (!marker) { return; } - const decoration = this._terminal.registerDecoration({ marker, layer: 'top' }); + const decoration = this._terminal.registerDecoration({ marker, width: 2, layer: 'top' }); if (!decoration) { return; } @@ -284,7 +284,7 @@ export class TerminalQuickFixAddon extends Disposable implements ITerminalAddon, updateLayout(this._configurationService, e); this._accessibilitySignalService.playSignal(AccessibilitySignal.terminalQuickFix); - const parentElement = (e.closest('.xterm') as HTMLElement).parentElement; + const parentElement = e.closest('.xterm')?.parentElement; if (!parentElement) { return; }