remove old perf action and some cleanup #65400

microsoft · Dec 27, 2018 · 97569f6 · 97569f6
1 parent 5dcbfad
commit 97569f6
Show file tree

Hide file tree

Showing 4 changed files with 57 additions and 331 deletions.
diff --git a/src/vs/workbench/parts/performance/electron-browser/actions.ts b/src/vs/workbench/parts/performance/electron-browser/actions.ts
diff --git a/src/vs/workbench/parts/performance/electron-browser/performance.contribution.ts b/src/vs/workbench/parts/performance/electron-browser/performance.contribution.ts
@@ -7,14 +7,22 @@ import { localize } from 'vs/nls';
 import { MenuRegistry } from 'vs/platform/actions/common/actions';
 import { CommandsRegistry } from 'vs/platform/commands/common/commands';
 import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
+import { LifecyclePhase } from 'vs/platform/lifecycle/common/lifecycle';
 import { Registry } from 'vs/platform/registry/common/platform';
+import { Extensions, IWorkbenchContributionsRegistry } from 'vs/workbench/common/contributions';
 import { Extensions as Input, IEditorInputFactory, IEditorInputFactoryRegistry } from 'vs/workbench/common/editor';
-import { PerfviewInput } from 'vs/workbench/parts/performance/electron-browser/perfviewEditor';
+import { PerfviewContrib, PerfviewInput } from 'vs/workbench/parts/performance/electron-browser/perfviewEditor';
 import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
 import './startupProfiler';
 import './startupTimings';
 import './stats';
 
+
+Registry.as<IWorkbenchContributionsRegistry>(Extensions.Workbench).registerWorkbenchContribution(
+ PerfviewContrib,
+ LifecyclePhase.Ready
+);
+
 Registry.as<IEditorInputFactoryRegistry>(Input.EditorInputFactories).registerEditorInputFactory(
  PerfviewInput.Id,
  class implements IEditorInputFactory {
@@ -35,7 +43,7 @@ CommandsRegistry.registerCommand('perfview.show', accessor => {
 });
 
 MenuRegistry.addCommand({
- id: 'perfview.show',
+ id: 'workbench.action.appPerf',
  category: localize('show.cat', "Developer"),
- title: localize('show.label', "Startup Performance (2)")
+ title: localize('show.label', "Startup Performance")
 });