tune hover behavior to allow alt to switch from debug hover to regula…

…r hover and that the mouse move does not hide the regular hover fixes #84561
microsoft · Sep 18, 2020 · ce95d7e · ce95d7e
1 parent c4aa010
commit ce95d7e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/src/vs/editor/contrib/hover/hover.ts b/src/vs/editor/contrib/hover/hover.ts
@@ -78,7 +78,6 @@ export class ModesHoverController implements IEditorContribution {
 
  this._didChangeConfigurationHandler = this._editor.onDidChangeConfiguration((e: ConfigurationChangedEvent) => {
  if (e.hasChanged(EditorOption.hover)) {
- this._hideWidgets();
  this._unhookEvents();
  this._hookEvents();
  }
@@ -100,7 +99,7 @@ export class ModesHoverController implements IEditorContribution {
  this._toUnhook.add(this._editor.onKeyDown((e: IKeyboardEvent) => this._onKeyDown(e)));
  this._toUnhook.add(this._editor.onDidChangeModelDecorations(() => this._onModelDecorationsChanged()));
  } else {
- this._toUnhook.add(this._editor.onMouseMove(hideWidgetsEventHandler));
+ this._toUnhook.add(this._editor.onMouseMove((e: IEditorMouseEvent) => this._onEditorMouseMove(e)));
  this._toUnhook.add(this._editor.onKeyDown((e: IKeyboardEvent) => this._onKeyDown(e)));
  }
 

diff --git a/src/vs/workbench/contrib/debug/browser/debugEditorContribution.ts b/src/vs/workbench/contrib/debug/browser/debugEditorContribution.ts
@@ -269,9 +269,6 @@ export class DebugEditorContribution implements IDebugEditorContribution {
  this.altPressed = false;
  this.editor.updateOptions({ hover: { enabled: false } });
  listener.dispose();
- if (this.hoverRange && debugHoverWasVisible) {
- this.showHover(this.hoverRange, false);
- }
  }
  });
  }