Cmd+Space hint (#45589)

microsoft · Mar 26, 2018 · fe76fb2 · fe76fb2
1 parent a82ae79
commit fe76fb2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/vs/workbench/browser/parts/quickinput/quickInput.ts b/src/vs/workbench/browser/parts/quickinput/quickInput.ts
@@ -34,7 +34,7 @@ export class QuickInputService extends Component implements IQuickInputService {
 
  private static readonly ID = 'workbench.component.quickinput';
  private static readonly MAX_WIDTH = 600; // Max total width of quick open widget
- // private static readonly MAX_ITEMS_HEIGHT = 20 * 22; // Max height of item list below input field
+ // private static readonly MAX_ITEMS_HEIGHT = 20 * 22; // TODO Max height of item list below input field
 
  private layoutDimensions: Dimension;
  private container: HTMLElement;
@@ -145,7 +145,8 @@ export class QuickInputService extends Component implements IQuickInputService {
  }
 
  this.inputBox.setValue('');
- this.inputBox.setPlaceholder(options.placeHolder || '');
+ // TODO: Localize shortcut.
+ this.inputBox.setPlaceholder(options.placeHolder ? localize('quickInput.ctrlSpaceToSelectWithPlaceholder', "{1} ({0} to toggle)", 'Cmd+Space', options.placeHolder) : localize('quickInput.ctrlSpaceToSelect', "{0} to toggle", 'Cmd+Space'));
  // TODO: Progress indication.
  this.checkboxList.setElements(await picks);
 

diff --git a/src/vs/workbench/browser/parts/quickinput/quickInputBox.ts b/src/vs/workbench/browser/parts/quickinput/quickInputBox.ts
@@ -16,7 +16,7 @@ import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
 
 const $ = dom.$;
 
-const DEFAULT_INPUT_ARIA_LABEL = localize('quickInputBoxAriaLabel', "Type to narrow down results.");
+const DEFAULT_INPUT_ARIA_LABEL = localize('quickInputBox.ariaLabel', "Type to narrow down results.");
 
 export class QuickInputBox {