-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to prevent side panel from opening #105270
Comments
request makes sense but really extensions should not aggressively show the channel. a setting would help the user now but any extensions behaving responsibly may not be able to reliably convey info. |
Issue seems to be closed now but I can't find any setting to disable the output window from showing up |
I would really like to know why this was closed as "out of scope". The reasoning provided by @sbatten seems incomplete to me. If extension authors should not re-open the panel anyway, why not give the users more control over the panels. What exactly is at risk of breaking, and why is a badly designed extension breaking more important than the overall user experience? The only reason I use the Panel is the terminal. I sometimes look at the "Output" Panel for triaging an issue I am having but every single time an extension has opened the output panel it was to the immediate detriment of my experience while providing absolutely no positive value in return. To the point that whenever the Output panel opens itself I immediately dismiss it again without looking at the contents - because it is never relevant or informative. Also worth noting that all the extensions I have had this displeasure with are authored by Microsoft. |
"out-of-scope" they said... |
@sandy081 please reopen this. |
I opened #203478 with an extremely thorough explanation on why the issue is still relevant. @sandy081 closed it too, and appears to also be the one closing many of the others. @sandy081 Do you have some sort of a vendetta against this specific feature? You've been closing these as duplicates even though it's very clear that the issue is not resolved. Users are trying to make their voice heard and you're almost single-handedly shutting down the discussions. |
The first time this issue was reported (that I can find) was #33262 from August 2017. Over 6 years ago. The fact that one was (incorrectly) closed has been used as a justification to close every other ticket addressing the problem, even though it has still not been resolved. |
So I guess that's it then? Multiple people point out a major issue, write up detailed reports, and suggest good solutions, and one person can just come along and just shut down the report because of a failure to understand the issue? And then that person just ignores all requests to reopen the ticket for multiple days, despite closing it instantly and without any sort of review? You know, I really thought VS Code was better than that. But now the Microsoft-ness is coming through loud and clear. |
Is #199946 going to mitigate this by allowing Output to be detached into its own window? |
@gjsjohnmurray No. That just shifts the problem elsewhere, and making an entire window pop up constantly would be even worse. The issue is plugins being able to force the output panel to open. Many of them abuse (or misuse) the API to dump output constantly that is not useful. It's been said that the fault is with those plugins (and that's technically true) but in that way it's just like pop-up windows on the internet. We added pop-up blockers because they were so annoying. VS Code effectively needs the same thing for its own "pop-up output window" nuisance. The argument has been made that "the output is important so we must allow it" - to which I say who are you to decide what the user wants? That's an insult to the users, who generally do, in fact, know better than Microsoft how they want their editor configured. |
Actually I misinterpreted what the referenced change does. It merely opens a |
Still calling on @sandy081 (who closed this and then just completely abandoned us) to reopen one of these tickets. The issue still exists. |
@jstm88 which of your installed extension is/are causing this? Have you raised issues with the extension author(s)? Or considered not using the extension(s)? Somewhat ironic that your frequent comments on multiple issues are starting to feel to me like the kind of unwanted "spam" you're apparently getting from extensions you choose to install. |
@gjsjohnmurray There are multiple extensions that do this. One of the most common (and the worst offender on my setup) is Microsoft's own C extension. The argument that we shouldn't do anything is flawed, and it's frustrating that a very small number of developers are using it as a weapon against users to shut down discussion. I completely understand that, yes, this is technically the extensions' fault. However, with thousands of extensions and who knows how many of them misusing the API, it is absolutely hopeless to get everyone to fix every extension. That's why we absolutely need an option to prevent focus-stealing on the Output window. There is no other way to fix this problem. I outline in my ticket how this could be done as a per-extension setting, which would allow the user to have control over which of these extensions are allowed to interrupt workflow. A global option would just be easier to implement. |
To add on to StringEpsilon's list, the Salesforce CLI Integration also focuses the Output channel when you use its various right-click menu menu actions in the file explorer such as I appreciate that the extension's UX is largely the responsibility of the extension authors, but as I am effectively forced to use this extension to work in that ecosystem I also want to have control of behavior that's so impactful to my experience of using VSCode itself. I'd love a setting for this. |
Thanks for all your input! I think combining this with the |
@benibenj I can see some sense in combining this with Do Not Disturb, but I don't think everyone who's interested in this issue (Panel appearing suddenly because extension forces its output channel to display) will want to set Do Not Disturb (i.e. suppress all non-error notifications) for an extension as the only way of suppressing Panel-popup. Related - the only doc references I've been able to find for Do Not Disturb are in release notes:
Perhaps its also time this feature got into the regular doc. |
I would agree. Ideally I would just set a setting once and never ever be bothered again by any extension. But having a way of dealing with individual bad extensions would definitely a huge wine. That is, if setting the extension to do not disturb does not get rid of all toast notifications. While I don't like those either, they are not nearly as disruptive and more often than not actually informative. Having less information because I don't want to get ripped out of my terminal is not quite optimal. |
I'm facing a problem where this option would solve it. edit: i've opened an issue on extensions repo too: |
@benibenj any more thoughts on this? I'm willing improve my PR if it's deemed to need changes, e.g. greater configurability. |
We are not 100% sure yet how this should work. We are currently thinking it could behave the same way notification does. This would mean:
Currently we are thinking not to have a global toggle but just per extension (no action like do not disturb for notifications) Let me know if you have any thoughts about this approach. I still need to discuss this with @bpasero. Let me get back to you next week. Please ping me if I forget. Edit: |
I'd much prefer a general solution that keeps my desired bottom panel afixed than one where I have to chase down every offending extension and check how I can disable the behavior. For instance sometimes I have to disable the extra terminal and the opening of the At the very least, I'd prefer If I don't have to remember to check every single extension I install and make sure to add it to the "no output panel" list. |
Ok, lets start off with a single setting for the ouput channel, similar to what is suggested in the PR #205225; |
The new |
Verification steps: #205225 (comment) |
Verified, but that status bar indicator is very subtle. |
When I see “but…” and “…very subtle” together, that tells me it’s done right. 😁 The editor’s job is to get out of my way so I can code. The amount of bloat (especially with the AI fad) is insane, so everything we can do to hide/remove the cruft is a major win. |
I've this kind of messages that keep popping up the side panel
I guess it's a linter or whatever having small issues. There are multiples culprit, here it's "YAML Support", but I saw other ones. My issue is, I don't give a damn, and it's taking space, and popping up again and again if I close it. So far I could only stick it to the bottom and reduce it to the smallest size before closing... but now and then I like to open an integrated terminal, which lives in the same panel. Then the focus keep being stolen by those same messages.
So I'ld like a VS way to get rid of those. Asking plugin by plugin will never work, even if I knew where to report about those.
The text was updated successfully, but these errors were encountered: