Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting UI: support color settings #106041

Open
aeschli opened this issue Sep 3, 2020 · 3 comments
Open

setting UI: support color settings #106041

aeschli opened this issue Sep 3, 2020 · 3 comments
Assignees
@rzhao271
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Milestone
Backlog

Comments

@aeschli
Copy link
Contributor

aeschli commented Sep 3, 2020

#105811 added the screencastMode.mouseIndicatorColor setting representing a color

  • open the JSON settings (JSON), add "screencastMode.mouseIndicatorColor": "#ff00ff"
  • see that there's a color decorator and that there's validation if you change the value to an invalid color

Now open the same setting in the settings UI:

  • enter an invalid value #foo. No error
  • a color decorator would also be nice

The color support in JSON comes from annotating the configuration schema with "format": "color-hex"
@roblourens
Copy link
Member

#105854

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 3, 2020
@lszomoru
Copy link
Member

lszomoru commented Sep 3, 2020

Validation has been added with #105854 but I do agree that it would be nice to have a color decorator in the settings UI as well, similar to the JSON file. I will reopen this issue to track adding the color decorator in the settings UI, and I already started looking at that so I will take ownership of the issue.

@lszomoru lszomoru reopened this Sep 3, 2020
@lszomoru lszomoru assigned lszomoru and unassigned roblourens Sep 3, 2020
@lszomoru lszomoru added screencast-mode settings-editor VS Code settings editor issues and removed *duplicate Issue identified as a duplicate of another issue(s) labels Sep 3, 2020
@lszomoru lszomoru added this to the September 2020 milestone Sep 3, 2020
@lszomoru lszomoru added the feature-request Request for new features or functionality label Sep 3, 2020
@roblourens
Copy link
Member

Sure, we had #50697 for that but I will close it as a dupe

@roblourens roblourens mentioned this issue Sep 3, 2020
Closed
@kieferrm kieferrm mentioned this issue Sep 14, 2020
Closed
41 tasks
@lszomoru lszomoru modified the milestones: September 2020, October 2020 Sep 28, 2020
@lszomoru lszomoru modified the milestones: October 2020, November 2020 Oct 19, 2020
@lszomoru lszomoru modified the milestones: November 2020, Backlog Nov 25, 2020
@rzhao271 rzhao271 assigned rzhao271 and unassigned rzhao271 Oct 15, 2021
@lszomoru lszomoru removed their assignment Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzhao271 rzhao271

Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @lszomoru @aeschli @rzhao271