Clicking "Accounts" menu does not open the menu instantly

[bpasero]

Update: reproduces in web + desktop

Steps to Reproduce:

1. open a Codespace
2. wait until it is loaded
3. try various activity bar items that open menus (gear menu, accounts, main menu, home indicator)

=> 🐛 somehow the accounts menu only opens for me after a delay, as if something was resolved when clicking?

[bpasero]

This still reproduces @RMacfarlane @sbatten

[sbatten]

does this still repro? maybe its imperceptible to me?

[bpasero]

Yeah still seems slightly delayed to me, can we not check the code and see if a longer running promise prevents the menu from showing?

[sbatten]

looks like we fetch session info every time, so this probably adds some delay. @TylerLeonhardt maybe this can be cached and updated separately

vscode/src/vs/workbench/browser/parts/activitybar/activitybarActions.ts

Lines 216 to 290 in 8d2a6fa

	protected override async resolveMainMenuActions(accountsMenu: IMenu, disposables: DisposableStore): Promise<IAction[]> {
	await super.resolveMainMenuActions(accountsMenu, disposables);
	const otherCommands = accountsMenu.getActions();
	const providers = this.authenticationService.getProviderIds();
	const allSessions = providers.map(async providerId => {
	try {
	const sessions = await this.authenticationService.getSessions(providerId);
	const groupedSessions: { [label: string]: AuthenticationSession[]; } = {};
	sessions.forEach(session => {
	if (groupedSessions[session.account.label]) {
	groupedSessions[session.account.label].push(session);
	} else {
	groupedSessions[session.account.label] = [session];
	}
	});
	return { providerId, sessions: groupedSessions };
	} catch {
	return { providerId };
	}
	});
	const result = await Promise.all(allSessions);
	let menus: IAction[] = [];
	const authenticationSession = this.environmentService.options?.credentialsProvider ? await getCurrentAuthenticationSessionInfo(this.environmentService, this.productService) : undefined;
	result.forEach(sessionInfo => {
	const providerDisplayName = this.authenticationService.getLabel(sessionInfo.providerId);
	if (sessionInfo.sessions) {
	Object.keys(sessionInfo.sessions).forEach(accountName => {
	const manageExtensionsAction = disposables.add(new Action(`configureSessions${accountName}`, localize('manageTrustedExtensions', "Manage Trusted Extensions"), '', true, () => {
	return this.authenticationService.manageTrustedExtensionsForAccount(sessionInfo.providerId, accountName);
	}));
	const signOutAction = disposables.add(new Action('signOut', localize('signOut', "Sign Out"), '', true, () => {
	return this.authenticationService.removeAccountSessions(sessionInfo.providerId, accountName, sessionInfo.sessions[accountName]);
	}));
	const providerSubMenuActions = [manageExtensionsAction];
	const hasEmbedderAccountSession = sessionInfo.sessions[accountName].some(session => session.id === (authenticationSession?.id));
	if (!hasEmbedderAccountSession || authenticationSession?.canSignOut) {
	providerSubMenuActions.push(signOutAction);
	}
	const providerSubMenu = disposables.add(new SubmenuAction('activitybar.submenu', `${accountName} (${providerDisplayName})`, providerSubMenuActions));
	menus.push(providerSubMenu);
	});
	} else {
	const providerUnavailableAction = disposables.add(new Action('providerUnavailable', localize('authProviderUnavailable', '{0} is currently unavailable', providerDisplayName)));
	menus.push(providerUnavailableAction);
	}
	});
	if (providers.length && !menus.length) {
	const noAccountsAvailableAction = disposables.add(new Action('noAccountsAvailable', localize('noAccounts', "You are not signed in to any accounts"), undefined, false));
	menus.push(noAccountsAvailableAction);
	}
	if (menus.length && otherCommands.length) {
	menus.push(disposables.add(new Separator()));
	}
	otherCommands.forEach((group, i) => {
	const actions = group[1];
	menus = menus.concat(actions);
	if (i !== otherCommands.length - 1) {
	menus.push(disposables.add(new Separator()));
	}
	});
	return menus;
	}

[TylerLeonhardt]

Yeah that seems like a reasonable ask since it goes to the extension host and back, today.

[gjain-7]

This issue has existed since 2 years!
But only recently have I encountered this.