High memory usage on local machine when flushing a large number of characters to screen

[Bobholamovic]

Issue Type: Performance Issue

Just one step to reproduce it:

base64 /dev/urandom

And you'll see the memory usage of VSCode on the local machine surges, until the program stops working.

Does this have anything to do with a local screen buffer?

Extension version: 0.56.0
VS Code version: Code 1.51.1 (e5a624b, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.18363
Remote OS version: Linux x64 4.15.0-74-generic

[roblourens]

Does this sound like anything that we might have an issue for @meganrogge?

I guess I would expect

And you'll see the memory usage of VSCode on the local machine surges

to some extent, but not

until the program stops working.

[meganrogge]

I haven't seen anything similar. Can confirm it only happens for remote windows.

[Bobholamovic]

@roblourens Well, what I meant was that the program would stop working because of the OOM error. But shouldn't we expect the resources of the remote server to be heavily consumed instead of the local machine, since the program is actually running on the remote server?

[roblourens]

It will use some memory on the local side, partly for the screen buffer but partly just from lots of allocations in JS that don't get garbage collected right away. Should not be leaky though.

[meganrogge]

Duplicate of #111562