Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab wrap - allow to change height of tabs #113832

Closed
swinder0161 opened this issue Jan 5, 2021 · 11 comments
Closed

Tab wrap - allow to change height of tabs #113832

swinder0161 opened this issue Jan 5, 2021 · 11 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues

Comments

@swinder0161
Copy link
Contributor

swinder0161 commented Jan 5, 2021

  • VSCode Version: 1.53.0-insider
  • Commit: a48ef56
  • Date: 2021-01-05T05:22:22.983Z
  • Electron: 11.1.0
  • Chrome: 87.0.4280.88
  • Node.js: 12.18.3
  • V8: 8.7.220.29-electron.0
  • OS Version: Darwin x64 20.2.0:

This version has #106448 integrated and can wrap tabs to multiple lines. #70413

After enabling the wrapping, it seems too much height for tabs and screen space is wasted.

It will be good to have an option to sqeeze the tab height so that rows can move up.

as an optional feature, also an option ot change horizontal width of tabs in shrink mode will be good to have

@swinder0161
Copy link
Contributor Author

@bpasero here is the issue I discussed in PR #70413

@bpasero bpasero added feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues labels Jan 5, 2021
@bpasero bpasero changed the title [Tab Wrapping] Allow to change height of tabs Wrapping tabs: Allow to change height of tabs Jan 5, 2021
@vannaka
Copy link

vannaka commented Jan 6, 2021

@swinder0161 have you written any code for this issue? I can't find a PR for it and you haven't linked to any?

@bpasero here is the issue I discussed in PR #70413

In your comment you say 'PR', did you mean 'issue'? This page that we are having this conversation on is an 'issue' not a 'PR'.

@swinder0161
Copy link
Contributor Author

@vannaka is it related to PR #70413
I have not yet written any code. Maybe next week I might have some time to do it.

@swinder0161
Copy link
Contributor Author

@bpasero I see another issue that edirot font size change also changes the font size of filename in tab. so if some one increases editor font size, which I normally do to not strain my eyes, the tabs row takes more vertical space.

@bpasero
Copy link
Member

bpasero commented Jan 7, 2021

The editor font size is not used anywhere outside the editor, i think you talk about zooming?

@swinder0161
Copy link
Contributor Author

swinder0161 commented Jan 7, 2021

Yes you are correct my zoom was set to 1 and now -0.5 looks nice. incidentally my old font size(12) matched the font size in tab text. Now I changed font size in editor to 10 but tab font size is still bigger ~12

image

@yume-chan
Copy link
Contributor

I found #42253 when searching, not sure whether the old hacks in there are still valid after wrapping tabs.

@bpasero bpasero changed the title Wrapping tabs: Allow to change height of tabs Tab wrap - allow to change height of tabs Jan 27, 2021
@bpasero
Copy link
Member

bpasero commented Mar 1, 2021

/duplicate 42253

@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality workbench-tabs VS Code editor tab issues
Projects
None yet
Development

No branches or pull requests

5 participants
@swinder0161 @bpasero @yume-chan @vannaka and others