Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: consistent context menus in workbench layout #114822

Closed
2 tasks done
bpasero opened this issue Jan 23, 2021 · 4 comments
Closed
2 tasks done

Test: consistent context menus in workbench layout #114822

bpasero opened this issue Jan 23, 2021 · 4 comments

Comments

@bpasero
Copy link
Member

bpasero commented Jan 23, 2021

Refs: #113757

Complexity: 2

Authors: @bpasero, @sandy081

Create Issue


We tried to make the context menus that appear throughout the workbench to be consistent. This impacts the following right-clickable locations:

  • activity bar (either any entry directly or empty space between)
  • panel header (either an entry directly or empty space between)
  • side bar (either a view directly or the title area at the top)

The experience should be consistent:

  • you see an explicit "Hide XY" entry as first entry if you right click on a specific entry
  • you always see a list of entries with checkboxes to toggle visibility
  • you never see a "Hide XY" entry when you right click into empty space
  • you see management related entries at the end (e.g. "Move Sidebar Right")
@bpasero bpasero added this to the January 2021 milestone Jan 23, 2021
@bpasero bpasero changed the title Test: context menus in workbench layout Test: consistent context menus in workbench layout Jan 23, 2021
@ArturoDent
Copy link

ArturoDent commented Jan 24, 2021

Very small thing on Activity Bar. Context menu reads Hide 'Extensions' for example but Hide Accounts (Accounts not in quotes). Otherwise, it all looked consistent. Windows 10.

@bpasero
Copy link
Member Author

bpasero commented Jan 25, 2021

@ArturoDent thanks for testing this, yes I would say that is intentional because view names can be anything including multiple words and potentially coming from extensions so I felt it better to surround with quotes.

@lszomoru
Copy link
Member

Tested on macOS 👏🏻

@lszomoru lszomoru removed their assignment Jan 26, 2021
@ornelladotcom
Copy link

Also tested on macOS 🎉

@ornelladotcom ornelladotcom removed their assignment Jan 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants