Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Mac universal build #114974

Closed
6 tasks done
deepak1556 opened this issue Jan 26, 2021 · 7 comments
Closed
6 tasks done

Test: Mac universal build #114974

deepak1556 opened this issue Jan 26, 2021 · 7 comments
Assignees
Milestone

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Jan 26, 2021

Refs: #113851

Complexity: 2

Create Issue


Background

We are looking to make universal build as the default for mac which can run natively on x86_64 as well as arm64. As a start in this iteration the default download on the website will point to universal build while we will still provide arch specific downloads.

Screen Shot 2021-01-25 at 8 32 38 PM

Testing

The website bits are pending to be merged and published to ppe https://github.com/microsoft/vscode-website/pull/924. So for testing use the builds from https://builds.code.visualstudio.com/builds/insider

  • Download universal build and install on x86_64 machine which had a previously running native x86_64 copy.

    • verify that universal app continues your session from where you had left off on the previous native version without any changes to configurations
    • verify your everyday setup just works
    • verify automatic update works
  • Download universal build and install on arm64 machine which had a previously running native arm64 copy.

    • verify that universal app continues your session from where you had left off on the previous native version without any changes to configurations
    • verify your everyday setup just works
    • verify automatic update works
@deepak1556
Copy link
Collaborator Author

I have assigned this item based on the members of team who have access to devices with M1 chips, feel free to reassign or unassign if you are blocked on other items. Thanks!

@bpasero
Copy link
Member

bpasero commented Jan 26, 2021

The only way I figured out how to ensure I am on universal build is by checking the size of the application. Not sure we want a way to show this in e.g. the about dialog to diagnose issues?

@jrieken
Copy link
Member

jrieken commented Jan 26, 2021

For me this isn't working

@joaomoreno
Copy link
Member

joaomoreno commented Jan 26, 2021

@deepak1556 You forgot to update the Create Issue link, so people have created issues related to the wrong TPI. The best way to create a TPI is from the templates, not from existing TPIs: https://github.com/microsoft/vscode/wiki/Writing-Test-Plan-Items

@chrmarti
Copy link
Contributor

@deepak1556 I don't have a silicon Mac. I'll just test with Intel, so you can potentially unassign yourself.

@kieferrm
Copy link
Member

kieferrm commented Jan 26, 2021

I've got an M1, I'll test the apple silicon -> universal direction.

@kieferrm kieferrm removed their assignment Jan 26, 2021
@paulmillr
Copy link

universal check can be done like this:

❯ file Visual\ Studio\ Code\ -\ Insiders.app/Contents/MacOS/Electron 
Visual Studio Code - Insiders.app/Contents/MacOS/Electron: Mach-O 64-bit executable arm64

Universal is like this:

app: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64:Mach-O 64-bit executable arm64]
app (for architecture x86_64):	Mach-O 64-bit executable x86_64
app (for architecture arm64):	Mach-O 64-bit executable arm64

@deepak1556 deepak1556 removed their assignment Jan 26, 2021
@jrieken jrieken closed this as completed Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants