Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish notebook markdown extension point #116393

Closed
6 of 8 tasks
mjbvz opened this issue Feb 11, 2021 · 1 comment
Closed
6 of 8 tasks

Polish notebook markdown extension point #116393

mjbvz opened this issue Feb 11, 2021 · 1 comment
Assignees
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Feb 11, 2021

Follow up on #106701, which added a new extension point that lets extensions contribute markdown extensions for notebooks.

To enable the new render API, set:

"notebook.experimental.useMarkdownRenderer": true,

Todos

  • Make a more thorough test of accessibility with these changes
    • Improve focus tracking
    • Test screen reader
  • When pre-rendering the notebook cells on first load, look at cell position cache instead of just getting first five cells
  • Move the math contribution into a new extension
  • Make sure that only core extensions can fully replace the markdown renderer for now
  • Figure out markdown extensions should be contributed. Right now they come in the same way replacement markdown renderers do
  • Improve drag + drop of cells. Currently there are noticeable delays
@mjbvz mjbvz self-assigned this Feb 11, 2021
mjbvz added a commit that referenced this issue Feb 11, 2021
For #116393

Also removes some logging and improves drag/drop responsiveness
@mjbvz mjbvz added this to the February 2021 milestone Feb 16, 2021
@rebornix rebornix removed their assignment Feb 24, 2021
@mjbvz mjbvz modified the milestones: February 2021, March 2021 Feb 25, 2021
@mjbvz mjbvz modified the milestones: March 2021, April 2021 Mar 22, 2021
@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 20, 2021

I've split the remaining issues out:

#121256 For API review
#118594 for accessibility

@mjbvz mjbvz closed this as completed Apr 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants