Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear terminal before launching another debuggee in terminal #116699

Closed
weinand opened this issue Feb 15, 2021 · 3 comments
Closed

Clear terminal before launching another debuggee in terminal #116699

weinand opened this issue Feb 15, 2021 · 3 comments
Assignees
@weinand
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone
March 2021

Comments

@weinand
Copy link
Contributor

weinand commented Feb 15, 2021 •
edited
Loading

In VS Code the DAP runInTerminal request tries to launch a new debug session in the same integrated terminal if the previous session has finished. A consequence of this approach is that the previous commands and output will remain visible in the integrated terminal which is confusing for some users.

This request asks for introducing a setting to automatically clear the integrated terminal before starting a new debug session.

@testforstephen this feature request is a replacement for your DAP feature request.
@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 15, 2021
@weinand weinand added this to the On Deck milestone Feb 15, 2021
@weinand weinand self-assigned this Feb 15, 2021
@weinand weinand mentioned this issue Feb 15, 2021
Closed
@weinand weinand modified the milestones: On Deck, March 2021 Feb 22, 2021
@kieferrm kieferrm mentioned this issue Mar 8, 2021
Closed
76 tasks
@weinand
Copy link
Contributor Author

weinand commented Mar 16, 2021

@testforstephen the new feature is now available under a new setting "debug.terminal.clearBeforeReusing".

lramos15 pushed a commit that referenced this issue Mar 16, 2021
@weinand @lramos15
new debug setting for clearing a terminal before reusing; fixes #116699
28b9bdc
lramos15 pushed a commit that referenced this issue Mar 18, 2021
@Tyriar @lramos15
Don't show select default shell when proc support not registered
2ce4bf6 
Fixes #118978

explorerModel: add toString to explorerItem for more precise error message

multicursor aria polish

fixes #118964
fixes #118965

debt - consolidate process usage

:lipstick: process use

fix #118970

accessibility: 1000 page size as default

Do no install repo on Raspberry Pi OS (#118826)

* Do no install repo on Raspberry Pi OS

* 💄

Co-authored-by: João Moreno <joao.moreno@microsoft.com>

firefox: do not use ctrl+shift+P for show all commands since it is taken, make sure F1 is rendered

untitledHint: introduce default for workbench.editor.untitled.hint

better aria label for the remote host status bar item

fixes #118839

Fix #118958

Fix #118953

Remove unused

Remove only

Rename setting gettingStarted.hiddenCategories => workbench.welcomePage.hiddenCategories
Fixes #118990

Don't create markdown previews if cell is in edit mode

unHidePreview should also update dimensions

update seti theme. fixes #118912

test view/model range convertion with hidden cells.

share drag impl for builtin and custom md renderer.

adopt multi select in drag and drop. drag the focus or selection around the focus.

update list item height on markdown cell ctor as we might already warm up the viewport.

Fix border overlap in quick pick UI (#119039)

Fixes #107737

debt - some more process and platform 💄

debt - use product quality instead of probing for name

Adds RemoteHub to api allow list

fix build

mark APIs as deprecated

fix: typo

custom editors - make conflict resolution actions appear (#118949)

Workspace trust changes (#119017)

* Add dialog button customisation and reject promise if cancelled
* Use different promises to modal/soft requests

new debug setting for clearing a terminal before reusing; fixes #116699

Pick up fix for #117054

Update types

Ports: service -> application, defaults ->unconfigured

ignore file events while saving, more logging, #118992

more deprecations

Fix task start firing with invalid process ID in dependsOn task

This was caused by the env var relaunch @debounce decorator that was added to
prevent the process from relaunching multiple times when multiple extensions
contribute to the environment. This caused the reuseTerminal call to not have
the new processReady promise ready immediately after reuseTerminal was called.
The fix which seems safe it to just move the @debounce over to relaunchTerminal
that tasks doesn't use.

Fixes #118256

Fixes #119011: Wait for the vscode API to become available before launching extension tests
@testforstephen
Copy link

@weinand thanks. I tried in latest insider (2021-03-22) in macOS, overall it looks good. Just a minor concern about the clear behavior.

By default, launch a new debug session will auto keep the new terminal command at the beginning of my viewport.

Screen.Recording.2021-03-22.at.16.47.16.mov

But if i have scrolled the terminal manually, then launch in terminal won't clear the terminal and scroll to the latest terminal line.

Screen.Recording.2021-03-22.at.16.51.45.mov

@weinand
Copy link
Contributor Author

weinand commented Mar 22, 2021

@testforstephen thanks for testing.
Strange, scrolling should not have an effect because clearing the terminal is done by running the "clear" command in the terminal.

@weinand weinand mentioned this issue Mar 22, 2021
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
3 participants
@weinand @testforstephen and others