Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable local reconnect for task terminals #117578

Closed
Tyriar opened this issue Feb 24, 2021 · 1 comment
Closed

Disable local reconnect for task terminals #117578

Tyriar opened this issue Feb 24, 2021 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal Integrated terminal issues verified Verification succeeded
Milestone
February 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 24, 2021 •
edited
Loading

As per #117408 (comment)
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal Integrated terminal issues labels Feb 24, 2021
@Tyriar Tyriar added this to the February 2021 milestone Feb 24, 2021
@Tyriar Tyriar self-assigned this Feb 24, 2021
@Tyriar Tyriar mentioned this issue Feb 24, 2021
Closed
Tyriar added a commit that referenced this issue Feb 24, 2021
@Tyriar
Pass should persist to pty service
8042e9b 
Fixes #117417
Part of #117578
@Tyriar
Copy link
Member Author

Tyriar commented Feb 24, 2021 •
edited
Loading

Still need to check shouldPersist when setting layout information

@Tyriar Tyriar closed this as completed in 90cc8b1 Feb 24, 2021
@meganrogge meganrogge added the verified Verification succeeded label Feb 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
3 participants
@Tyriar @meganrogge and others