Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Come up with more robust approach to detached processes in local reconnect #117588

Closed
Tyriar opened this issue Feb 24, 2021 · 3 comments
Closed

Come up with more robust approach to detached processes in local reconnect #117588

Tyriar opened this issue Feb 24, 2021 · 3 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
March 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 24, 2021

Related #116467

Right now on reload we explicitly tell pty service to detach the process, this does not detect when the window crashes ungracefully.

Repro:

  1. Create 2 windows
  2. Create a terminal
  3. Crash one window (kill proc)
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Feb 24, 2021
@Tyriar Tyriar added this to the March 2021 milestone Feb 24, 2021
@Tyriar Tyriar changed the title Come up with more robust approach to detaches processes in local reconnect Come up with more robust approach to detached processes in local reconnect Feb 24, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Mar 18, 2021

I think this is fixed now after adopting the code in remote and supporting attach to session which asks the renderers which processes are detached #118241

@Tyriar Tyriar closed this as completed Mar 18, 2021
@lramos15 lramos15 added the verification-steps-needed Steps to verify are needed for verification label Mar 26, 2021
@lramos15
Copy link
Member

@Tyriar I'm not sure how to verify this one, I assume I follow the steps in #118241 which is already verified meaning this one is good now too?

@Tyriar
Copy link
Member Author

Tyriar commented Mar 26, 2021

Yep those steps are the same 👍

@Tyriar Tyriar added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Mar 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
3 participants
@Tyriar @lramos15 @meganrogge