Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List: Fix shift click to expand selection #118044

Closed
joaomoreno opened this issue Mar 3, 2021 · 2 comments
Closed

List: Fix shift click to expand selection #118044

joaomoreno opened this issue Mar 3, 2021 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders list-widget List widget issues verified Verification succeeded
Milestone
March 2021

Comments

@joaomoreno
Copy link
Member

  • We should move the focus to the element that gets shift clicked.
  • We probably need a separate trait, ie anchor, in order to achieve this
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug list-widget List widget issues labels Mar 3, 2021
@joaomoreno joaomoreno added this to the March 2021 milestone Mar 3, 2021
@joaomoreno joaomoreno self-assigned this Mar 3, 2021
@joaomoreno joaomoreno mentioned this issue Mar 3, 2021
Closed
@joaomoreno
Copy link
Member Author

@rebornix Can you verify this one too?

@joaomoreno joaomoreno added verification-needed Verification of issue is requested and removed verification-needed Verification of issue is requested labels Mar 10, 2021
aeschli pushed a commit that referenced this issue Mar 10, 2021
@joaomoreno @aeschli
list: anchor trait
0f2c6cf 
fixes #118044
@kieferrm kieferrm mentioned this issue Mar 15, 2021
Closed
76 tasks
@isidorn isidorn added the verified Verification succeeded label Mar 25, 2021
@isidorn
Copy link
Contributor

isidorn commented Mar 25, 2021

Seems to behave fine for me -> verified

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders list-widget List widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
3 participants
@joaomoreno @isidorn and others