Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: upload a folder that already exists leads to error #123469

Closed
bpasero opened this issue May 10, 2021 · 1 comment
Closed

Web: upload a folder that already exists leads to error #123469

bpasero opened this issue May 10, 2021 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded web Issues related to running VSCode in the web
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 10, 2021

Steps:

  • be in web (yarn web is fine)
  • drag and drop a folder that already exists into the explorer
  • confirm to overwrite
Error: Unable to read file 'memfs:/sample-folder/xyz' (Error: Unable to read file 'memfs:/sample-folder/xyz' that is actually a directory)
    at FileService.doReadFileStream (fileService.ts:529)
    at async FileService.doReadFile (fileService.ts:451)
    at async DeleteOperation.perform (bulkFileEdits.ts:254)
    at async BulkFileEdits.apply (bulkFileEdits.ts:387)
    at async BulkEdit._performFileEdits (bulkEditService.ts:97)
    at async BulkEdit.perform (bulkEditService.ts:82)
    at async BulkEditService.apply (bulkEditService.ts:199)
    at :8080/async http:/localhost:8080/static/out/vs/workbench/contrib/files/browser/explorerService.js:122
@bpasero bpasero added file-explorer Explorer widget issues web Issues related to running VSCode in the web labels May 10, 2021
@isidorn isidorn added this to the May 2021 milestone May 10, 2021
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label May 20, 2021
@isidorn
Copy link
Contributor

isidorn commented May 20, 2021

When creating ResourceFileEdits we have to specify if it is a folder.

@bpasero bpasero added the verified Verification succeeded label Jun 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @isidorn and others