Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript doc visible for aliased imports, but not for single ones. #12360

Closed
Elarcis opened this issue Sep 21, 2016 · 6 comments
Closed

Typescript doc visible for aliased imports, but not for single ones. #12360

Elarcis opened this issue Sep 21, 2016 · 6 comments
Assignees
Labels
typescript Typescript support issues
Milestone

Comments

@Elarcis
Copy link

Elarcis commented Sep 21, 2016

  • VSCode Version: 1.5.2
  • OS Version: Windows 7 Service Pack 1
  • Typescript version: 2.0.2

Steps to Reproduce:

  1. have a myClass.ts file exporting a MyClass class. Write some /** */ doc for that class.
  2. In another file, try the following two ways of importing identifiers:
import { MyClass } from 'myModule';
MyClass // When hovering MyClass, the written doc is not visible.
import * as myModule from 'myModule';
myModule.MyClass // When hovering MyClass, the written doc appears.

It seems logical that the doc should appear in both cases, is this due to Typescript 2?

@Elarcis Elarcis changed the title Typescript 2.0.2 doc visible for alias imports, but not for single ones. Typescript 2.0.2 doc visible for aliased imports, but not for single ones. Sep 21, 2016
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues labels Sep 21, 2016
@chrmarti chrmarti changed the title Typescript 2.0.2 doc visible for aliased imports, but not for single ones. Typescript doc visible for aliased imports, but not for single ones. Sep 21, 2016
@chrmarti
Copy link
Collaborator

Can reproduce with the given example and TypeScript 1.8 in todays insider build.

@dbaeumer dbaeumer assigned waderyan and unassigned dbaeumer Sep 22, 2016
@waderyan
Copy link

Repro'd with latest TypeScript release bits - release-2.0.5 branch.

Here is code to copy and paste.

test.ts

import { MyClass } from './myModule';
MyClass // When hovering MyClass, the written doc is not visible.

import * as myModule from './myModule';
myModule.MyClass // When hovering MyClass, the written doc appears.

myModule.ts

/**
 * Some documentation
 */
export class MyClass {

}

sending to TypeScript language service repo.

@waderyan
Copy link

This issue was moved to microsoft/TypeScript#11099

@ramya-rao-a ramya-rao-a added this to the October 2016 milestone Sep 29, 2016
@ramya-rao-a
Copy link
Contributor

Moving to a future milestone as this cannot be verified at the moment

@mousetraps
Copy link
Contributor

Moving to a future milestone as this cannot be verified at the moment.

@jrieken jrieken modified the milestones: January 2017, November 2016 Dec 8, 2016
@alexdima
Copy link
Member

LOL

Attempt no. 4 at verification failed => two options:
A) this item should be kept open with the "bug" label + "upstream" label. Then we can use it as a tracking item for the upstream bug.
B) otherwise, this item should be kept closed without the "bug" label as it was moved somewhere else.

I vote for B)

@alexdima alexdima removed the bug Issue identified by VS Code Team member as probable bug label Jan 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

8 participants