Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to migrate extensions (python!) off of shell and shellArgs terminal settings #123930

Closed
meganrogge opened this issue May 15, 2021 · 4 comments
Assignees
Labels
extensions Issues concerning extensions terminal Integrated terminal issues terminal-profiles under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@meganrogge
Copy link
Contributor

No description provided.

@meganrogge meganrogge added debt Code quality issues terminal Integrated terminal issues terminal-profiles extensions Issues concerning extensions and removed debt Code quality issues labels May 15, 2021
@meganrogge meganrogge added this to the May 2021 milestone May 15, 2021
@Tyriar Tyriar added the debt Code quality issues label May 15, 2021
@Tyriar
Copy link
Member

Tyriar commented May 21, 2021

I recommended the Python extension do this #121760 (comment)

I suggest once the recovery build ships (tomorrow?), in the Python extension check if the user has set defaultProfile but not shell or shellArgs and warn them that the default profile won't be used in this case. Since #123174 will be in the recovery build, that should catch all the bad cases

This can remain until the shell/shellArgs are lower priority to profiles. Tracking that in #123171, fyi @karrtikr I'd recommend subscribing to that issue

@Tyriar Tyriar closed this as completed May 21, 2021
@Tyriar Tyriar added under-discussion Issue is under discussion for relevance, priority, approach and removed debt Code quality issues labels May 21, 2021
@Tyriar
Copy link
Member

Tyriar commented May 21, 2021

Python issue microsoft/vscode-python#16175

@karrtikr
Copy link
Contributor

in the Python extension check if the user has set defaultProfile but not shell or shellArgs and warn them that the default profile won't be used in this case

Are you suggesting that we show a warning prompt?

@Tyriar
Copy link
Member

Tyriar commented May 21, 2021

@karrtikr yes if you think people will get confused otherwise, optional though.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions terminal Integrated terminal issues terminal-profiles under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants