-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening a Custom Editor Removes All Text Editors with Same File Open in Other Columns #124134
Comments
@andreamah This depends on what custom editor. Some custom editors specifically state that they do not support multiple documents per resource and therefore we must close it to respect the extension authors choice. |
I see. I noticed that this happens with the markdown static preview and hex editor. As for the static preview, I notice that is it possible to have it open in two different columns and toggle between the modes in both sides. Not too sure if it is expected to do this, though. |
The hex editor cannot be opened more than once for the same resource. I don't think that the static preview has this same limitation |
I think that it is disposed here: https://github.com/microsoft/vscode/blob/main/src/vs/workbench/services/editor/browser/editorOverrideService.ts#L137 |
That dispose is because we return an entirely new input to be opened. I don't think that's the issue, but does removing it fix the problem? |
Removing it fixes the problem, but I'm sure that doing that causes other things to go wrong? |
\closedWith a069768 |
Does this issue occur when all extensions are disabled?: Yes/No
Related to #84520
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: