Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop execution / Interrupt overlap #128245

Closed
rebornix opened this issue Jul 6, 2021 · 3 comments · Fixed by #160738
Closed

Stop execution / Interrupt overlap #128245

rebornix opened this issue Jul 6, 2021 · 3 comments · Fixed by #160738
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue

Comments

@rebornix
Copy link
Member

rebornix commented Jul 6, 2021

The Jupyter extension contributes a notebook controller with an interrupt handler, the Stop Execution will then call the interrupt handler directly, which does the same as the Interrupt command contributed by the extension. We may want to hide the Interrupt command.

It's arguable that if we want to change the title of Stop Execution to Interrupt when the controller contributes interrupt handler but it's also impl details which users might not care.

@IanMatthewHuff
Copy link
Member

Agreed. Jupyter does call it interrupt, but my bet would be customers wouldn't be too confused by either name for the command.

@IanMatthewHuff IanMatthewHuff removed their assignment Jul 6, 2021
@DonJayamanne
Copy link
Contributor

Personally I don't think we even need a command (i.e. an icon on the toolbar).

@greazer greazer transferred this issue from microsoft/vscode-jupyter Jul 8, 2021
@rebornix rebornix added polish Cleanup and polish issue debt Code quality issues labels Oct 11, 2021
@rebornix rebornix removed their assignment Oct 11, 2021
@rebornix rebornix removed the notebook label Oct 21, 2021
@rebornix rebornix assigned rebornix and unassigned DonJayamanne Sep 12, 2022
@rebornix rebornix added this to the September 2022 milestone Sep 12, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@IanMatthewHuff @rebornix @DonJayamanne @tanhakabir @vscodenpa and others