Search Editor still has 10000 line limit when search.maxResults is set to a value larger than 10000

[alexzhuaz]

Issue Type: Bug

1. Set search.maxResults to a value larger than 10000
2. Search some text in file which may have results more than 10000
3. Click "Open in editor" in search panel
4. The search editor shows
   "10000 results - 1 file
   The result set only contains a subset of all matches. Be more specific in your search to narrow down the results." and only 10000 results shown in search editor

VS Code version: Code 1.58.0 (2d23c42, 2021-07-08T06:54:55.083Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: Yes
Remote OS version: Linux x64 4.15.0-136-generic

A/B Experiments

vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551:30311712
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30322572
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30340121
vscod805:30301674
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
vsccppwtct:30329789
pythonvssor306cf:30340756
bridge0708:30335490

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• search.maxResults setting not working in search editor (#128641)
• Increase the number of cursors from 10000 (#81589)

[JacksonKearl]

Accidentally already created a walkthrough of how to resolve this in #128661 so I'll post it here:

To reproduce, set the max results setting to some larger value, and run a search in the search editor which has more results than the value:

Access search editor with:

You can start by changing the limit passed here to read from the configurationService

vscode/src/vs/workbench/contrib/searchEditor/browser/searchEditor.ts

Line 490 in d7712ed

maxResults: 10000,

Then, you should add a way for the search to be re run with no limit. See what happens in the search from the sidebar, whose code is here: https://github.com/microsoft/vscode/blob/1fc68f3cf274141942b424894645a4f7096ec1f1/src/vs/workbench/contrib/search/browser/searchView.ts#L0-L1 for how to make that change.

[vlwkaos]

Hello, @JacksonKearl , I would like to work on this issue.

As-is: Search Editor has maxResults fixed to 10000
To-Be: Should use a maxResult value from configureationService and with no limit if value is null

Am I understading the issue correctly?

[JacksonKearl]

@vlwkaos yes that is correct. Thanks!

[Nirajn2311]

Hey @vlwkaos, have you started working on this? If not, I'm interested on picking it up.

[vlwkaos]

Hey @vlwkaos, have you started working on this? If not, I'm interested on picking it up.

@Nirajn2311 I've been busy so I have not done much, so you can pick it up. I realized it requires more time than I previously expected. As far as I see, making search editor to rerun the search results with polling like the search view requires some work...

[JacksonKearl]

As far as I see, making search editor to rerun the search results with polling like the search view requires some work...

It is by design that the search editor does not stream results, this causes undesirable behavior in an editor context when you may be in the process of manipulating the results. For this ticket simply respecting the search.maxResults setting is sufficient.

[vlwkaos]

As far as I see, making search editor to rerun the search results with polling like the search view requires some work...

It is by design that the search editor does not stream results, this causes undesirable behavior in an editor context when you may be in the process of manipulating the results. For this ticket simply respecting the search.maxResults setting is sufficient.

In that case, I have just done that, however, I still need to resolve what to do when the maxResult is null, because the editor will hang and crash. What would you suggest I do?

[Nirajn2311]

It's cool, I'll pick up another issue.