-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to resolve buttons on QuickPickItems lazy #131401
Comments
This is interesting and not currently supported even in Core atm. I wonder though if this issue would be almost fixed with addressing this: The fix for that being that if the same ids are present when you set (of course the concept of |
That would definitely help. Do you know why we decided that QuickPickItems are not live at least in the case where I create a quick pick list using the API? |
It's a good question. Historically it seemed like we didn't want to complicate the API too much:
It would get a bit complicated because the user is responsible for creating the QP items... for most cases, simply preserving the cursor top when the QP items have the same ids and order is enough of a fix and the user just needs to add an (this again is theoretical since today there's no concept of an |
I just added the proposed API for a property that you can set that will allow you to control when the scroll position should be kept. That's being tracked here: It's not quite as elegant as enabling "live objects" in the quick pick but it should be enough to fix your issue without having to break the previous assumption that the items were static. |
Closing this to use that ^ |
I need to resolve the buttons for QuickPickItems lazily (e.g. I need to make service requests). Currently I need to set the
items
on the quick pick which can lead to strange behavior if the user types, moves the mouse or otherwise interacts with the quick pick.Would it be possible to support a style where setting the
buttons
property updates the item in the UI?The text was updated successfully, but these errors were encountered: