Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Filter Test UI with a negated tag #133350

Closed
ashgti opened this issue Sep 17, 2021 · 1 comment · Fixed by #133358
Closed

[FR] Filter Test UI with a negated tag #133350

ashgti opened this issue Sep 17, 2021 · 1 comment · Fixed by #133358
Assignees
@connor4312
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2021

Comments

@ashgti
Copy link
Contributor

ashgti commented Sep 17, 2021

Splitting this out from #129456 (comment)

In the Test UI you can filter by text or exclude text using ! and filter by a @tag. It would be nice if we could also negate tags in the filter like !@tag to exclude a specific tag.
@connor4312 connor4312 added feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors testing Built-in testing support labels Sep 17, 2021
@connor4312 connor4312 added this to the Backlog milestone Sep 17, 2021
@connor4312
Copy link
Member

connor4312 commented Sep 17, 2021 •
edited
Loading

Starting point, this is where tag filtering happens:

vscode/src/vs/workbench/contrib/testing/common/testExplorerFilterState.ts

Line 31 in 16ab8be

readonly onlyTags: ReadonlySet<string>;

@ashgti ashgti mentioned this issue Sep 18, 2021
Merged
@rzhao271 rzhao271 modified the milestones: Backlog, September 2021 Oct 1, 2021
@rzhao271 rzhao271 added verification-needed Verification of issue is requested verified Verification succeeded labels Oct 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2021
Development

Successfully merging a pull request may close this issue.

Adding support for negated test tag filtering to the testingExplorerView ashgti/vscode
4 participants
@ashgti @connor4312 @rzhao271 and others