Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better UX for recommended extensions #13456

Closed
jaime-olivares opened this issue Oct 11, 2016 · 6 comments
Closed

Better UX for recommended extensions #13456

jaime-olivares opened this issue Oct 11, 2016 · 6 comments
Assignees
@ramya-rao-a
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality on-testplan
Milestone
June 2018

Comments

@jaime-olivares
Copy link

jaime-olivares commented Oct 11, 2016 •
edited
Loading

Suggestions for improving the recommended extensions functionality:

  1. Whenever I choose the new 'Configure Workspace Recommended Extensions" option, the list of currently installed extensions should be included rather than an empty json array. Adding one by one is really painful.
  2. When viewing the list of installed extensions and I click one of them for looking at the details, in the header topbar, next to the [Uninstall] button, there should be another [Recommend] button for automatically adding it to the current workspace.
  3. When looking at the list of recommended extensions (filter @recommended:workspace), there should be an 'install all' option.
@jaime-olivares jaime-olivares changed the title Better UX for recommended extension Better UX for recommended extensions Oct 11, 2016
@joaomoreno
Copy link
Member

  1. Probably not a good idea since most of the cases you'd end up deleting lines from the file. What you'd want there is language services (similar to intellisense in package.json dependencies).
  2. We could add a Add to Workspace Recommendations context action to the extension in the viewlet. I wouldn't make it too prominent.
  3. Good idea, which we could apply to a lot of other concepts, like Update all.

@joaomoreno joaomoreno removed their assignment Oct 11, 2016
@jaime-olivares
Copy link
Author

For 1 intellisense would help. Whatever avoids me to manually copy/paste the extension names.
As a second alternative, deleting the unneeded extension names is still better than copy/paste.

@sandy081
Copy link
Member

I think providing intellisense will be helpful and makes sense than copying the installed extensions.

@sandy081 sandy081 added extensions Issues concerning extensions feature-request Request for new features or functionality labels Dec 7, 2016
@sandy081 sandy081 added this to the Backlog milestone Dec 7, 2016
This was referenced May 5, 2017
Closed
Merged
@sandy081
Copy link
Member

1 is implemented. Leaving to @ramya-rao-a for the rest as she currently working on improving it.

@sandy081 sandy081 assigned ramya-rao-a and unassigned sandy081 Nov 20, 2017
@ramya-rao-a
Copy link
Contributor

The 3rd point is done as well. There is "Install All" action on the header of the workspace recommendations section.

@reyronald reyronald mentioned this issue May 24, 2018
Merged
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, June 2018 Jun 13, 2018
@kieferrm kieferrm mentioned this issue Jun 15, 2018
Closed
52 tasks
reyronald added a commit to reyronald/vscode that referenced this issue Jun 22, 2018
@reyronald
Add "Recommend" action to extension viewlet
d4128c6 
Related to microsoft#13456
ramya-rao-a pushed a commit that referenced this issue Jun 24, 2018
@reyronald @ramya-rao-a
Add "Recommend" action to extension viewlet (#50419)
5eea6bc 
* Add "Recommend" action to extension viewlet

Related to #13456

* Address PR requested changes

* Change functionality and UX

- Button goes from "Add to workspace recommendations" (clickable) to
  "Adding to workspace recommendations..." (unclickable) to
  "Added to workspace recommendations" (unclickable).
- It is only visible if the current extension is installed and there's
  at least one folder in the root that doesn't have it recommended yet.
  In other words, if it's already recommended in every folder of the root,
  it is not visible.
- In a single-root setup, it's immediately added to the recommendations.
- In a multi-root setup, a quick-pick is displayed with only the folders
  where it is not yet recommended available as options.
- In a multi-root setup, the button will go back to
  "Add to workspace recommendations" (clickable) instead of the
  unclickable state if there are still folders remaining where the
  current extension is not yet recommended.
- An error or success notification is displayed after the work is done.
- Configuration files are created if don't exist, modified otherwise.

* Don't show the button if ext is recommended in ANY folder

In the previous commit, the button would be displayed as long as there
was at least one folder in the workspace where the extension wasn't
recommended.

Now, the button will be displayed only if the current extension is not
recommended in any of the folders, as suggested in
#50419 (comment)

* Improvements based on PR suggestions

- Lowercasing the extension ID before comparing
- Directly styling & labeling the button on the `run` command after work is done instead of calling `update`.
- Fix & delete unnecessary styles

* Expose feature as command instead of button

After a discussion with @ramya-rao-a and other members of the team,
it was decided that it wasn't reasonable to have a dedicated button for
a feature that's rarely used in such a visible place.

So instead, the action will be exposed as a command that will only be
available when there's an extension open in the editor area. In contrast
with the previous implementation, this has the added benefit of
allowing the user to use this action to recommend uninstalled
extensions as well.

* Simplify conditions for AddToRecommendations action

* Move comments so that they dont get erased when recommendations are added programatically

* Remove from unwanted before adding to recommendations

* Array improvements

* Friendly error msg
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 26, 2018 •
edited
Loading

In the latest Insiders and in the upcoming stable update of 1.25.0, there are new commands that will let you add an extension to Workspace recommendations. Thanks @reyronald and @JacksonKearl

image

With this all points mentioned in the initial list is complete.
So closing

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
extensions Issues concerning extensions feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
4 participants
@joaomoreno @jaime-olivares @sandy081 @ramya-rao-a