-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move management of xterm into a new "XtermTerminal" class #136055
Milestone
Comments
7 tasks
Tyriar
added a commit
that referenced
this issue
Oct 29, 2021
Tyriar
added a commit
that referenced
this issue
Nov 2, 2021
Tyriar
added a commit
that referenced
this issue
Nov 2, 2021
Tyriar
added a commit
that referenced
this issue
Nov 2, 2021
Tyriar
added a commit
that referenced
this issue
Nov 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Pull out most xterm handling from
TerminalInstance
into its own class that encapsulates addons, latest write/parse, _enableWebglRenderer/other renderer stuff, customkeyhandler?, etc. The goal is to makeTerminalInstance
much smaller and enable easy unit testing of previously coreTerminalInstance
behavior by not having so many service dependencies.xterm
as public ITerminalInstance to avoid creating passthrough functions like scrollToTopxterm.raw
as public but only to TerminalInstance (ie. don't expose on XtermTerminal's interface)TerminalInstance
will be mostly a glue class (process manager <-> xterm), not intended to be unit testable but by integration testsThe text was updated successfully, but these errors were encountered: