Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move terminal's registerEditor call into TerminalEditorService #136058

Closed
Tracked by #136065
Tyriar opened this issue Oct 28, 2021 · 0 comments
Closed
Tracked by #136065

Move terminal's registerEditor call into TerminalEditorService #136058

Tyriar opened this issue Oct 28, 2021 · 0 comments
Assignees
@Tyriar @meganrogge
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Milestone
November 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2021

Move editorResolverService.registerEditor part of TerminalService.ctor into TerminalEditorService. Create a request attach event or similar to fix dep on ITerminalGroupService.
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Oct 28, 2021
@Tyriar Tyriar added this to the November 2021 milestone Oct 28, 2021
@Tyriar Tyriar mentioned this issue Oct 28, 2021
Closed
7 tasks
@Tyriar Tyriar closed this as completed in de69c40 Nov 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
3 participants
@Tyriar @meganrogge and others