Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace search (search.exclude) glob not correctly matching all .txt files #137855

Closed
aplotor opened this issue Nov 25, 2021 · 2 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@aplotor
Copy link

aplotor commented Nov 25, 2021

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.62.3
  • OS Version:
    image

Steps to Reproduce:

  1. "search.exclude": {"**/*.txt": true}
  2. workspace search does not exclude txt files starting with "# " (e.g., "# filename.txt")

edit: it seems this only happens if the excluded file is also open somewhere in the editor. not sure if this is expected behavior, but i think it would be better to have an option to adhere to the search.exclude settings regardless of whether an excluded file is open or not.

@aplotor aplotor closed this as completed Nov 25, 2021
@aplotor aplotor reopened this Nov 25, 2021
@aplotor aplotor changed the title windows terminal workspace search (search.exclude) glob not correctly matching all .txt files Nov 25, 2021
@gjsjohnmurray
Copy link
Contributor

edit: it seems this only happens if the excluded file is also open somewhere in the editor

/duplicate of #31819 and is mentioned at https://github.com/microsoft/vscode/wiki/Search-Issues#search-including-too-many-results

@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @gjsjohnmurray @aplotor and others