Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file nesting: impossible to discover nested files if icon theme hides folder arrows #141359

Closed
yume-chan opened this issue Jan 25, 2022 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues polish Cleanup and polish issue under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Milestone

Comments

@yume-chan
Copy link
Contributor

yume-chan commented Jan 25, 2022

Issue Type: Bug

Testing #141354

After setting "explorer.experimental.fileNesting.enabled": true and "explorer.experimental.fileNesting.expand": false, my nested files are completely hidden, and requires double-clicking the item to expand/collapse.

image
(stream.js also has nested stream.js.map)

This is because icon themes can hide the arrow next to folders in explorer (doc), one example is the vscode-icons icon theme I'm using, which has a vsicons.presets.hideExplorerArrows option (and Icons: Toggle Explorer Folder Arrows Visibility (User Level) command).

VS Code version: Code - Insiders 1.64.0-insider (2c967bf, 2022-01-24T05:14:33.015Z)
OS version: Darwin x64 21.2.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz (4 x 3500)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 7, 8, 7
Memory (System) 32.00GB (0.40GB free)
Process Argv --crash-reporter-id 4fd680f3-dbd8-413a-8c27-d5306e62c299
Screen Reader no
VM 0%
Extensions (29)
Extension Author (truncated) Version
vscode-javascript-repl ach 0.7.3
Bookmarks ale 13.2.2
toml be5 0.6.0
gitlens eam 11.7.0
prettier-vscode esb 9.1.0
copilot-nightly Git 1.7.4731
remotehub Git 0.22.0
rest-client hum 0.24.6
monkey-patch ioc 0.1.16
vscode-env Iro 0.1.0
search-node-modules jas 1.3.0
rust-analyzer mat 0.3.917
csharp ms- 1.24.0
remote-containers ms- 0.214.0
remote-ssh ms- 0.71.2021121615
remote-ssh-edit ms- 0.71.2021121615
remote-wsl ms- 0.64.2
hexeditor ms- 1.9.3
js-debug-nightly ms- 2022.1.2317
vscode-typescript-next ms- 4.6.20220124
vsliveshare ms- 1.0.5273
vscode-yaml red 1.3.0
reveal smu 1.2.7
workspace-config-plus Swe 0.2.2
luna-paint Tyr 0.12.0
vscode-icons vsc 11.8.0
cloudmusic YXL 9.8.1
markdown-all-in-one yzh 3.4.0
material-theme zhu 3.13.16
@JacksonKearl JacksonKearl added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues polish Cleanup and polish issue labels Feb 4, 2022
@JacksonKearl
Copy link
Contributor

@misolori any ideas here? I was considering some thing like using the description to show a message:
image

Or just an icon of some sort:
image

We could perhaps provide a default "nest parent" file icon and let themes customize it.

@JacksonKearl JacksonKearl added the under-discussion Issue is under discussion for relevance, priority, approach label Feb 4, 2022
@JacksonKearl JacksonKearl added this to the February 2022 milestone Feb 4, 2022
@miguelsolorio
Copy link
Contributor

I think in the case where the theme has chosen to hide the chevron, that is on the theme because that is what denotes a "folder". So creating a "nested parent" option would only help in this case as i wouldn't add additional meta data on the list item.

@yume-chan
Copy link
Contributor Author

image

How about let Code place a little folder icon at bottom right of the original file icon?

Maybe file icon theme authors need to create extra simplified folder icons, or maybe it's completely impossible because they will be too small.

@zzjin
Copy link

zzjin commented Feb 9, 2022

Sub little icon sounds great! Or maybe using plus(➕) to make a difference?

JacksonKearl pushed a commit that referenced this issue Mar 9, 2022
- Force nests to render with a twistie
- Resolve alignment issues by hiding nested parent icon to match folders
Fixes #142938, #141428, #141359
@JacksonKearl
Copy link
Contributor

Nest parents will now display a chevron even if folders do not.

@aeschli aeschli added the verified Verification succeeded label Mar 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues polish Cleanup and polish issue under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants