-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing the notebookDeprecated proposal #146831
Comments
Basically the requirement here is, we need the ability to map the webview We can add custom metadata, however now we need to ensure the serializer is updated to ignore such custom metadata (but they both live in two separate repos).
This isn't possible, on the renderer (webview) side the object is not the same as the object on the extension host.
There's no such thing in the webview |
👍 Yeah, way to go. The
Do you mean that the serializer lives in one repo and the controller/kernel in another? Can there be some "contract" that metadata properties of certain prefix aren't ever saved? |
Yes
Yes we could, was planning on avoiding this, as the contract is very loose here, basically the code will be if we have metadata named xyz, then don't save it. @mjbvz Would prefer if this API is not dropped just yet, let me check this and get back. |
@DonJayamanne Yes we don't need to rush removing this but I do want to make sure it happens at some point since this API proposal has already been lingering around for a while. I've opened microsoft/vscode-jupyter#9629 to track this debt work |
I think the assumption that we don't want metadata in the output could be challenged. We already put metadata in the kernel info. Adding it to the output doesn't seem bad to me. And writing metadata need only happen when we update an output. Output without metadata.ids could just skip supporting the plot viewer. Additionally we might not even need it. You could hash the contents of the image and when clicking the plot viewer or plot save button, pass the hash of the image. The extension side code could just look for this image in the output data. |
|
@pwang347 mentioned that this API might still be used by Data Wrangler, we want to make sure that they finish the migration before we remove it. |
@rebornix According to our product.json-based allow listing it isn't. Is data wrangler an extension or are they a fork? In the latter case we should be fine |
@jrieken It’s an extension. (Good day, everyone.) |
Thanks @sadasant - all should be good because it isn't allow-listed and therefore cannot use the API anyways |
@jrieken we do have this code snippet, which seems to be working I'm not familiar with the allow-list, but I recall chatting with @DonJayamanne previously about gaining access to the notebook proposed APIs. Not sure if the permissions are set at a different place/granularity. Thanks! |
Yes, I thought I had addressed those by providing the necessary information. |
You're right, my apologies. I don't believe we've explicitly requested for |
FYI @rebornix @DonJayamanne @mjbvz it seems like the output ID is now going stale in the latest Insiders version, this is causing the Data Wrangler launch button to not show up sometimes. I verified that the output ID is being updated correctly in VS Code stable. If this change was done intentionally, do we have an alternative way to figure out which cell an output renderer belongs to so that we can migrate off this API? |
NOt sure what you mean by this, please can you file an issue in Jupyter extension with steps to repro that. |
Strange, I can't seem to reproduce this anymore on Insiders, even on older versions of Jupyter and Python. I meant that the Multiple people reported seeing the problem as well, I'll check with them to see if it has been resolved. Otherwise will look into creating an issue. Thanks! |
The
notebookDeprecated
api proposal is currently not on track for finalization. It only contains a single propertyNotebookCellOutput.id
, which we believe is no longer useful or neededWe plan on removing this proposal it once all current consumers have migrated off it. Here's the current list:
Please check if your extension is using this api and if you have any concerns migrating off of it
The text was updated successfully, but these errors were encountered: