Ctrl+click into a relative filepath results in error

[joyceerhl]

1. Go to https://github.dev/microsoft/vscode/blob/ff7237ac1915950ea116b6f4d389f2575b3f0819/src/vs/workbench/api/browser/mainThreadSecretState.ts#L10
2. Ctrl+click on the relative filepath on L10: '../common/extHost.protocol'
3. 🐛 file fails to open with the following error
   

I repro this in v0.20.0 of GitHub Repositories so I don't think this is a regression.

VS Code appears to be trying to stat the vscode-vfs URI for this file, but the authority is missing, and Remote Repositories looks up the provider for a given vscode-vfs URI by checking the authority, so this is an invalid vscode-vfs URI. @bpasero do you happen to know what might be happening here?

[bpasero]

This originates from language support to find the reference for a symbol:

vscode/src/vs/editor/contrib/gotoSymbol/browser/goToCommands.ts

Lines 170 to 172 in 12e6b0b

	const next = model.firstReference()!;
	const peek = model.references.length > 1 && gotoLocation === 'gotoAndPeek';
	const targetEditor = await this._openReference(editor, editorService, next, this.configuration.openToSide, !peek);

I am not sure if this is coming from TypeScript, or possibly AnyCode, assigning some folks.

Btw easy to reproduce running out of sources with remote hub extension installed, even on desktop.

[bpasero]

What is also interesting is that all the other imports (such as 'vs/workbench/services/extensions/common/extHostCustomers'), do not allow to navigate 🤔

[mjbvz]

Pushed a fix for the authority part: #148940

However TS still returns a path without a file extension in this case. Will keep open to continue investigation but may depend on microsoft/TypeScript#47600

[joyceerhl]

This no longer repros 🎉