Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the textDocumentNotebook API proposal #147414

Closed
4 tasks done
Tracked by #149861
mjbvz opened this issue Apr 13, 2022 · 9 comments · Fixed by #149277
Closed
4 tasks done
Tracked by #149861

Removing the textDocumentNotebook API proposal #147414

mjbvz opened this issue Apr 13, 2022 · 9 comments · Fixed by #149277
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders notebook-api
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Apr 13, 2022

The textDocumentNotebook api proposal is currently not on track for finalization. See #102091 (comment) for details on this

As an workaround, today you can achieve the same functionality with:

vscode.workspace.notebookDocuments.find(notebook => notebook.getCells().some(cell => cell.document === myTextDocument))

We plan to remove the TextDocument.notebook property once all consumers have moved off of it:

If you are on this list, please look into migrating off of this api and let us know if you run into any issues with the migration

@rchiodo
Copy link
Contributor

rchiodo commented Apr 13, 2022

Looks like we weren't really using it. I removed our usage.

@mjbvz mjbvz added this to the On Deck milestone Apr 13, 2022
@alyssajotice
Copy link

Live Share is not using it. I will remove from our package.json.

@hsenag
Copy link

hsenag commented Apr 14, 2022

Copilot (and copilot nightly) @Krzysztof-Cieslak (let me know the correct owner if I got this wrong)

Thanks for the ping! We've ticketed this to deal with next week (I'm responding on behalf of @Krzysztof-Cieslak as he's not around today)

@Krzysztof-Cieslak
Copy link
Contributor

Hey, the use of the API is removed on the Copilot side of things, but the new version of the extension hasn't been released yet.

@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 30, 2022

@Krzysztof-Cieslak OK can you let me know when it is safe to remove on our side?

@hsenag
Copy link

hsenag commented Apr 30, 2022

@Krzysztof-Cieslak OK can you let me know when it is safe to remove on our side?

@mjbvz sorry we didn't update sooner: we (Copilot) did a release a few days ago so I think we're good for you to remove it.

@alyssajotice
Copy link

@mjbvz Live Share has not released yet - I will update here once we do.

@mjbvz
Copy link
Collaborator Author

mjbvz commented May 10, 2022

Confirmed that dot net is not using this. Will remove them from api consumers

@alyssajotice
Copy link

Live Share released yeserday - you can remove us from the list of consumers.

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders notebook-api
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants
@hsenag @rebornix @Krzysztof-Cieslak @mjbvz @rchiodo @alyssajotice @VSCodeTriageBot and others