Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No editor action to jump to next error in project #14783

Closed
atombender opened this issue Nov 1, 2016 · 11 comments
Closed

No editor action to jump to next error in project #14783

atombender opened this issue Nov 1, 2016 · 11 comments
Assignees
Labels
error-list Problems view feature-request Request for new features or functionality languages-diagnostics Source problems reporting on-testplan release-notes Release notes issues
Milestone

Comments

@atombender
Copy link

  • VSCode Version: 1.6.1

The editor action editor.action.marker.next ("Go to Next Error or Warning") only works for the current file. There seems to be no editor action for finding the next error in the project, even when the errors panel shows multiple files.

@rebornix
Copy link
Member

rebornix commented Nov 1, 2016

assign to @alexandrudima first per git blame but I think we might already have this issue reported.

@alexdima
Copy link
Member

alexdima commented Nov 7, 2016

fyi @jrieken @sandy081

@jrieken
Copy link
Member

jrieken commented Mar 2, 2018

@atombender @steveluc and other subscribed to this issue: What would be the expected behaviour when you have errors but not in the current file. Would you expect to replace the current file with the 'first' file with errors or is that only expected when coming from a file with errors?

@pragmascript
Copy link

pragmascript commented Mar 2, 2018

I would expect the same behaviour as "clicking" the same error in the problem panel.

@atombender
Copy link
Author

I would expect a new tab to be opened for the erroring file. I would expect that it would marked as a preview tab, so that multiple "next error" jumps forward would replace that new tab with the next file.

There has to be a "previous error" command, too, of course.

@jrieken
Copy link
Member

jrieken commented Mar 2, 2018

I would expect a new tab to be opened

Sure, but in which column. The same, I assume.

@atombender
Copy link
Author

Column? As in editor split pane? The same, yes.

@jrieken
Copy link
Member

jrieken commented Mar 5, 2018

Wrt to navigation order our plan is to use the order of the markers panel. Today F8 and the marker panels are two different components but the plan is to let them both use the same model. That means sorting and filtering will apply to F8.

  1. Files are sorted by the presence of at least one error, then by their filename

screen shot 2018-03-05 at 12 14 30

  1. When a filter is applied F8 only visits only markers from the filtered-view-model

screen shot 2018-03-05 at 12 14 59

Makes sense, feedback? Would you rather keep both components disconnected?

@sandy081
Copy link
Member

@jrieken You said, we will not move F8 functionality to Problems panel. If so, Let me know if there is anything to be done in Problems panel? User can already navigate problems across files in the panel.

@jrieken
Copy link
Member

jrieken commented Mar 19, 2018

@sandy081 you are off the hook, it already happened

@jrieken jrieken closed this as completed Mar 19, 2018
@jrieken jrieken added the release-notes Release notes issues label Mar 28, 2018
@monk-time
Copy link

monk-time commented Apr 7, 2018

@jrieken I don't quite understand why this change was implemented as a total replacement of the old behavior. I can see its usefulness in projects where all files have zero problems. But as it stands now it's no longer possible to use a keyboard shortcut (F8) to navigate through the problems only in the current file, which can be very useful when working on a project where many files have unresolved problems.

I don't think I'm the only one who has gotten used to the old behavior, and to me switching to an unrelated file on F8 (with no way to limit it only to the current file) is quite jarring and disruptive. I hope you would consider adding a way to configure this or at least a pair of keyboard bindings for the old behavior.

Also see #47367 (maybe that issue can be renamed as a feature request for a setting/bindings).

@vscodebot vscodebot bot locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-list Problems view feature-request Request for new features or functionality languages-diagnostics Source problems reporting on-testplan release-notes Release notes issues
Projects
None yet
Development

No branches or pull requests

7 participants