Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension fails activation when installing extensions from cli that have a common dependency #149309

Closed
jeanp413 opened this issue May 12, 2022 · 7 comments · Fixed by #159822
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@jeanp413
Copy link
Contributor

jeanp413 commented May 12, 2022

  • VS Code Version: stable and from sources

When launching the server and installing extensions using --install-extension that have a common dependency, one of the extensions will fail activating, prompting to reload VS Code.
For example installing, vscjava.vscode-java-pack and pivotal.vscode-spring-boot

  • vscjava.vscode-java-pack contains vscjava.vscode-java-test which depends on redhat.java
  • pivotal.vscode-spring-boot also depends on redhat.java
  • vscjava.vscode-java-pack installation task finishes first and then trying to activate vscjava.vscode-java-test fails as it doesn't await for redhat.java installation which is part of pivotal.vscode-spring-boot installation task

Steps to Reproduce:

  1. Open this branch https://github.com/gitpod-io/spring-petclinic/tree/jp/temp in gitpod or codespaces
  2. Observe vscjava.vscode-java-test will fail activating and a notification shows prompting to reload vscode
    error_iamge

cc @sandy081

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels May 12, 2022
@sandy081 sandy081 added this to the Backlog milestone May 12, 2022
@jeanp413
Copy link
Contributor Author

@sandy081 would you accept a PR fixing this? I took a look but it doesn't look something trivial to fix properly, I tried some changes but I don't think is a good fix

@sandy081
Copy link
Member

@jeanp413 PR would be always welcome. Agreed it is not trivial. Let's see if there is a simple fix that fixes this and won't cause any regressions.

@jeanp413
Copy link
Contributor Author

Created a PR #150333 with a possible fix

@akosyakov
Copy link
Contributor

@sandy081 ping, by any chance for July 🙏

@sandy081
Copy link
Member

@akosyakov I am sorry that I am on vacation so cannot be looked in July.

@vscodenpa vscodenpa added the insiders-released Patch has been released in VS Code Insiders label Sep 5, 2022
@aeschli aeschli added the verified Verification succeeded label Sep 28, 2022
@dlastrazeneca
Copy link

I was following this other issue, but it was marked as a duplicate and was therefore closed.

This isse seems to be closed as well, although the issue persists.

Specifically, it seems that VS Code Dev Containers installs extensions in alphabetical order, so that if an extension that comes later in the order is a pre-requisite for another that is earlier, then the installations will not behave as expected. Example, python is a pre-requisite for pylance, but comes later in alphabetical order. Thus, pylance requires a VS Code Session restart after building the Dev Container.

Is this issue fixed in VS Code Insiders, but not released yet?

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
@sandy081
Copy link
Member

@dlastrazeneca The issue you reported is using the build 1.71.* and this fix was pushed in 1.72.*. So please update your VS Code and try.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
6 participants