-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension fails activation when installing extensions from cli that have a common dependency #149309
Comments
@sandy081 would you accept a PR fixing this? I took a look but it doesn't look something trivial to fix properly, I tried some changes but I don't think is a good fix |
@jeanp413 PR would be always welcome. Agreed it is not trivial. Let's see if there is a simple fix that fixes this and won't cause any regressions. |
Created a PR #150333 with a possible fix |
@sandy081 ping, by any chance for July 🙏 |
@akosyakov I am sorry that I am on vacation so cannot be looked in July. |
I was following this other issue, but it was marked as a duplicate and was therefore closed. This isse seems to be closed as well, although the issue persists. Specifically, it seems that VS Code Dev Containers installs extensions in alphabetical order, so that if an extension that comes later in the order is a pre-requisite for another that is earlier, then the installations will not behave as expected. Example, Is this issue fixed in VS Code Insiders, but not released yet? |
@dlastrazeneca The issue you reported is using the build 1.71.* and this fix was pushed in 1.72.*. So please update your VS Code and try. |
When launching the server and installing extensions using
--install-extension
that have a common dependency, one of the extensions will fail activating, prompting to reload VS Code.For example installing,
vscjava.vscode-java-pack
andpivotal.vscode-spring-boot
vscjava.vscode-java-pack
containsvscjava.vscode-java-test
which depends onredhat.java
pivotal.vscode-spring-boot
also depends onredhat.java
vscjava.vscode-java-pack
installation task finishes first and then trying to activatevscjava.vscode-java-test
fails as it doesn't await forredhat.java
installation which is part ofpivotal.vscode-spring-boot
installation taskSteps to Reproduce:
vscjava.vscode-java-test
will fail activating and a notification shows prompting to reload vscodecc @sandy081
The text was updated successfully, but these errors were encountered: