Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet for jsx in js-file doesn't work anymore #14962

Closed
perbergstrom12 opened this issue Nov 4, 2016 · 6 comments
Closed

Emmet for jsx in js-file doesn't work anymore #14962

perbergstrom12 opened this issue Nov 4, 2016 · 6 comments
Assignees
@alexdima @aeschli
Labels
candidate Issue identified as probable candidate for fixing in the next release *duplicate Issue identified as a duplicate of another issue(s) verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October Recovery ...

Comments

@perbergstrom12
Copy link

  • VSCode Version: 1.71
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open a .js file with language mode JavaScript React
  2. type div and hit tab
@maroon1
Copy link

maroon1 commented Nov 4, 2016

I found tsx works well, but jsx doesn't work.

@mrmlnc
Copy link
Contributor

mrmlnc commented Nov 4, 2016 •
edited
Loading

Just a tip for those who will work on this issue: it is not related to Emmet.

VS Code defines the JavaScript React as JavaScript. Also comments from @aeschli: #14661 (comment)

TypeScript React

image

JavaScript React

image

@mrmlnc mrmlnc mentioned this issue Nov 7, 2016
Closed
@perbergstrom12 perbergstrom12 added this to the October Recovery 2016 milestone Nov 7, 2016
@perbergstrom12 perbergstrom12 added the candidate Issue identified as probable candidate for fixing in the next release label Nov 7, 2016
@alexdima
Copy link
Member

alexdima commented Nov 8, 2016

To investigate: this most likely has the same root cause as #14661

@alexdima
Copy link
Member

alexdima commented Nov 8, 2016

Same root cause as #14661

@alexdima alexdima closed this as completed Nov 8, 2016
@alexdima alexdima added *duplicate Issue identified as a duplicate of another issue(s) verification-needed Verification of issue is requested labels Nov 8, 2016
@alexdima
Copy link
Member

alexdima commented Nov 8, 2016

To the verifier: Please see comment in #14661

@alexdima alexdima mentioned this issue Nov 8, 2016
Closed
@chrmarti chrmarti added the verified Verification succeeded label Nov 9, 2016
@mrmlnc mrmlnc mentioned this issue Nov 15, 2016
Closed
@kaiwood kaiwood mentioned this issue Nov 22, 2016
Closed
@egamma egamma mentioned this issue Dec 12, 2016
Closed
@maximgatilin
Copy link

You can try this

"emmet.includeLanguages": {
    "javascript": "javascriptreact"
}

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

@aeschli aeschli

Labels
candidate Issue identified as probable candidate for fixing in the next release *duplicate Issue identified as a duplicate of another issue(s) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October Recovery 2016
Development

No branches or pull requests
7 participants
@perbergstrom12 @alexdima @aeschli @mrmlnc @chrmarti @maximgatilin @maroon1