Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyclic dependency: vs/editor/common/languages and vs/editor/common/tokenizationRegistry #150176

Closed
Tracked by #150025
jrieken opened this issue May 23, 2022 · 0 comments · Fixed by #150275
Closed
Tracked by #150025

Cyclic dependency: vs/editor/common/languages and vs/editor/common/tokenizationRegistry #150176

jrieken opened this issue May 23, 2022 · 0 comments · Fixed by #150275
Assignees
@alexdima
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
May 2022

Comments

@jrieken
Copy link
Member

jrieken commented May 23, 2022

related #150025

There is a cycling (runtime) dependency when not inlining/hoisting const enums between the mentioned files. The enum in question is: ColorId
@jrieken jrieken mentioned this issue May 23, 2022
Closed
15 tasks
@jrieken jrieken changed the title Cycling dependency: vs/editor/common/languages and vs/editor/common/tokenizationRegistry Cyclic dependency: vs/editor/common/languages and vs/editor/common/tokenizationRegistry May 23, 2022
@alexdima alexdima mentioned this issue May 24, 2022
Merged
alexdima added a commit that referenced this issue May 24, 2022
@alexdima
Fixes #150176: Extract code related to encoded token attributes to a …
b0d3569 
…separate file
@alexdima alexdima added this to the May 2022 milestone May 24, 2022
alexdima added a commit that referenced this issue May 24, 2022
@alexdima
Fixes #150176: Extract code related to encoded token attributes to a …
339c3a9 
…separate file (#150275)
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Extract code related to encoded token attributes to a separate file microsoft/vscode
4 participants
@jrieken @hediet @alexdima @vscodenpa