Support SGR ANSI escape sequences in TestRun.appendOutput API
#151964
Assignees
Labels
feature-request
Request for new features or functionality
insiders-released
Patch has been released in VS Code Insiders
on-testplan
testing
Built-in testing support
Milestone
Comments
connor4312
added
feature-request
connor4312
added a commit
that referenced
this issue
Feb 25, 2023
Previously, as in the issue this fixes #175377, messages without location were treated a little strangely, and messages for tests without a location were impossible to view. Them transient nature of the peek has been a longstanding overall experience papercut. This PR adds a Test Results panel which users can keep around as a persistent results view. It shares the code used to generate the peek view. With this PR, I've also tweaked it slightly so that the test 'history' is by default (unless toggled on) shown only in the panel, aligning the test errors peek more towards the diagnostics view, where the peek is a lighter, local view, and the panel shows everything. The only real 'addition' to the previously-peek content in this PR is that test output is shown when the top-level run node is selected. _Ideally_ this would be in a terminal where full ANSI codes and colors are supported, but it seems terminal land does not support this very well, and I want to eventually get ANSI color support in text mode anyway (#151964).
connor4312
added a commit
that referenced
this issue
Feb 25, 2023
Previously, as in the issue this fixes #175377, messages without location were treated a little strangely, and messages for tests without a location were impossible to view. Them transient nature of the peek has been a longstanding overall experience papercut. This PR adds a Test Results panel which users can keep around as a persistent results view. It shares the code used to generate the peek view. With this PR, I've also tweaked it slightly so that the test 'history' is by default (unless toggled on) shown only in the panel, aligning the test errors peek more towards the diagnostics view, where the peek is a lighter, local view, and the panel shows everything. The only real 'addition' to the previously-peek content in this PR is that test output is shown when the top-level run node is selected. _Ideally_ this would be in a terminal where full ANSI codes and colors are supported, but it seems terminal land does not support this very well, and I want to eventually get ANSI color support in text mode anyway (#151964).
This was referenced Jun 12, 2023
connor4312
added a commit
that referenced
this issue
Jun 17, 2023
Remove the old "test output terminal" stuff now that we use real terminals for showing output in the Test Results view. Move the "Show Output" buttons to reveal the Test Results view instead of opening the terminal. Closes #151964
connor4312
added a commit
that referenced
this issue
Jun 17, 2023
Remove the old "test output terminal" stuff now that we use real terminals for showing output in the Test Results view. Move the "Show Output" buttons to reveal the Test Results view instead of opening the terminal. Closes #151964
VSCodeTriageBot
added
unreleased
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
and others
This is a request for actual support for #148397, instead of just stripping the sequences. This would depend on #151963
The text was updated successfully, but these errors were encountered: