Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views location is not getting updated when switching profiles #154090

Closed
sandy081 opened this issue Jul 4, 2022 · 3 comments
Closed

Views location is not getting updated when switching profiles #154090

sandy081 opened this issue Jul 4, 2022 · 3 comments
Assignees
@sbatten @sandy081
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-views Workbench view issues
Milestone
September 2022

Comments

@sandy081
Copy link
Member

sandy081 commented Jul 4, 2022

  • Enable Settings Profiles
  • Create an empty profile P1 and move Timeline and Outline views to secondary sidebar as separate view containers
  • Create an empty profile P2
  • Switch from P2 to P1
    🐛 Timeline and Outline views are not moved to secondary sidebar and remain in explorer

Refreshing the window fixes it.
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues labels Jul 4, 2022
@sandy081 sandy081 added this to the July 2022 milestone Jul 4, 2022
@gjsjohnmurray
Copy link
Contributor

Similar to #153655

@sbatten
Copy link
Member

sbatten commented Jul 5, 2022 •
edited
Loading

interesting, looks like this is specific to generated view containers, as moving an entire container from activity bar to secondary side bar is reflected correctly

@sandy081
Copy link
Member Author

sandy081 commented Jul 6, 2022

yes. root cause is the order of storage events. This happens during storage change with views cache storage change comes first followed by view containers cache storage change.

@sandy081 sandy081 mentioned this issue Jul 27, 2022
Closed
@sandy081 sandy081 modified the milestones: July 2022, August 2022 Jul 27, 2022
@alexr00 alexr00 mentioned this issue Aug 23, 2022
Closed
3 tasks
@sandy081 sandy081 mentioned this issue Aug 24, 2022
Closed
@sandy081 sandy081 modified the milestones: August 2022, September 2022 Aug 25, 2022
@sandy081 sandy081 mentioned this issue Aug 30, 2022
Merged
sandy081 added a commit that referenced this issue Aug 31, 2022
@sandy081
Merge pull request #159611 from microsoft/sandy081/fix154090
99a7f26 
fix #154090
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 31, 2022
@roblourens roblourens added the verified Verification succeeded label Sep 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Milestone
September 2022
Development

No branches or pull requests
5 participants
@roblourens @sbatten @gjsjohnmurray @sandy081 @vscodenpa