Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky scroll doesn't follow editor.lineNumbers setting and always shows line numbers #156744

Closed
yume-chan opened this issue Jul 31, 2022 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll verified Verification succeeded
Milestone

Comments

@yume-chan
Copy link
Contributor

Type: Bug

Testing #156175

  1. Set "editor.lineNumbers": "off"
  2. Scroll down in a TypeScript function

image

Note that, In the screenshot, function test() is actually at line 1344, the gutter doesn't have enough space for 4 numbers.

Also, the visual separation between sticky lines and normal lines looks too subtle for me.

VS Code version: Code - Insiders 1.70.0-insider (12b08be, 2022-07-29T10:47:14.408Z)
OS version: Windows_NT x64 10.0.25169
Modes:
Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2

System Info
Item Value
CPUs AMD Ryzen 5 5600X 6-Core Processor (12 x 3700)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.91GB (14.05GB free)
Process Argv --crash-reporter-id f37b47d6-d028-418b-b006-0d623e833af7
Screen Reader no
VM 0%
Item Value
Remote Dev Container: Cerveau
OS Linux x64 5.10.102.1-microsoft-standard-WSL2
CPUs AMD Ryzen 5 5600X 6-Core Processor (12 x 3700)
Memory (System) 15.58GB (9.44GB free)
VM 0%
Extensions (18)
Extension Author (truncated) Version
Bookmarks ale 13.3.1
remotehub Git 0.39.2022072801
remote-containers ms- 0.243.0
remote-ssh ms- 0.85.2022071315
remote-ssh-edit ms- 0.80.0
remote-wsl ms- 0.66.3
remote-repositories ms- 0.16.0
material-icon-theme PKi 4.19.0
material-theme zhu 3.15.2
vscode-eslint dba 2.2.6
gitlens eam 12.1.2
prettier-vscode esb 9.5.0
copilot-nightly Git 1.36.6347
js-debug-nightly ms- 2022.7.2717
abracadabra nic 6.14.4
vscode-jest Ort 4.6.0
prisma Pri 4.1.0
code-spell-checker str 2.3.4
@alexdima alexdima assigned aiday-mar and unassigned alexdima Aug 2, 2022
@alexdima alexdima added editor-sticky-scroll bug Issue identified by VS Code Team member as probable bug labels Aug 2, 2022
@alexdima alexdima added this to the August 2022 milestone Aug 2, 2022
aiday-mar pushed a commit that referenced this issue Aug 3, 2022
Adapt sticky scroll to lineNumbers option. Fixing #156744
@lramos15 lramos15 added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants