Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky Scroll: In C#, namespace, struct, property should stick, attributes shouldn't stick #157375

Closed
CookieHCl opened this issue Aug 6, 2022 · 2 comments · Fixed by #157466
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@CookieHCl
Copy link

Does this issue occur when all extensions are disabled?: Almost yes (you need C# extension to make sticky scroll work, and issue happens when only C# extension is enabled)

  • VS Code Version: 1.70.0 (system setup), commit: da76f93
  • OS Version: Windows 11 21H2 (22000.832)

Case: namespace, property, attributes

Code:

code

Actual:

actual

Namespace, property doesn't appear, and attributes appear instead of actual class.

Expected:

expected

Namespace, property, and actual class should appear.

Case: struct

Code:

code2

Actual:

actual2

When you scroll down, Struct doesn't appear.

Expected:

expected2

Struct should appear.

@DingWeizhe
Copy link
Contributor

same problem in TypeScript decorator.
Code:
image

Actual:
image

@aiday-mar
Copy link
Contributor

aiday-mar commented Aug 10, 2022

Thank you for the feedback. This should be fixed by #157466 with @DingWeizhe's contribution

New behavior:

sticky-scroll-cs2

sticky-scroll-cs3

sticky-scroll-ts

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Aug 10, 2022
@vscodenpa vscodenpa added this to the August 2022 milestone Aug 10, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 11, 2022
@aiday-mar aiday-mar added the *duplicate Issue identified as a duplicate of another issue(s) label Aug 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders
Projects
None yet
6 participants