Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search decoration "badge" term ambiguous #162283

Open
joyceerhl opened this issue Sep 28, 2022 · 1 comment
Open

Search decoration "badge" term ambiguous #162283

joyceerhl opened this issue Sep 28, 2022 · 1 comment
Assignees
Labels
polish Cleanup and polish issue search Search widget and operation issues
Milestone

Comments

@joyceerhl
Copy link
Collaborator

Found while verifying #157462

Recording 2022-09-28 at 16 40 11

Not sure if this is avoidable but figured I'd file an issue anyway.

I also associate the term 'badge' with the number count, and consider the 'added'/'modified'/'deleted' letters which the new search badge setting toggles to be decorations. This initially caused some confusion about what the setting was supposed to do and whether it was working. Could we consider either clarifying the setting description or (if the badge terminology is not the right one) renaming the setting?

@andreamah
Copy link
Contributor

andreamah commented Sep 29, 2022

Recording 2022-09-28 at 16 40 11

Not sure if this is avoidable but figured I'd file an issue anyway.

Are you referring to how the badge moves to the left when you hover? If so, we're already tracking that here- #156300 :)

I also associate the term 'badge' with the number count, and consider the 'added'/'modified'/'deleted' letters which the new search badge setting toggles to be decorations. This initially caused some confusion about what the setting was supposed to do and whether it was working. Could we consider either clarifying the setting description or (if the badge terminology is not the right one) renaming the setting?

That's a good point. We call them file badges in the settings for explorer and other views.

image

But maybe we should consider renaming them to be more specific like you mentioned? Honestly, it is kind of vague to just refer to them as "badges".

@andreamah andreamah added the search Search widget and operation issues label Sep 29, 2022
@andreamah andreamah changed the title Search decoration badge skitters on hover Search decoration "badge" term ambiguous Oct 3, 2022
@andreamah andreamah added this to the Backlog milestone Oct 7, 2022
@andreamah andreamah added the polish Cleanup and polish issue label Oct 7, 2022
@rebornix rebornix assigned osortega and unassigned andreamah Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Cleanup and polish issue search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

3 participants