Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline completion preselects wrong/bogous suggestion item #164716

Closed
jrieken opened this issue Oct 26, 2022 · 1 comment · Fixed by #172421 or #179988
Closed

Inline completion preselects wrong/bogous suggestion item #164716

jrieken opened this issue Oct 26, 2022 · 1 comment · Fixed by #172421 or #179988
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug inline-completions verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Oct 26, 2022

  • use copilot
  • use postfix completion
  • 😕 I often see bogous selections in the suggest widget like below.

Screenshot 2022-10-26 at 13 58 50

@hediet hediet added bug Issue identified by VS Code Team member as probable bug inline-completions labels Oct 26, 2022
@hediet hediet added this to the November 2022 milestone Oct 26, 2022
@hediet hediet modified the milestones: November 2022, December 2022 Nov 28, 2022
hediet added a commit that referenced this issue Jan 25, 2023
hediet added a commit that referenced this issue Jan 25, 2023
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 25, 2023
@jrieken jrieken added the verified Verification succeeded label Jan 26, 2023
hediet added a commit that referenced this issue Jan 26, 2023
@jrieken jrieken removed verified Verification succeeded labels Feb 2, 2023
@jrieken jrieken modified the milestone: January 2023 Feb 2, 2023
@jrieken jrieken reopened this Feb 2, 2023
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Feb 2, 2023
@jrieken
Copy link
Member Author

jrieken commented Feb 2, 2023

Reopening, I just hit this again

Screenshot 2023-02-02 at 18 50 20


I have started an empty file with contents below. After completing InstantiationType copilot suggest something wrong and on manually request completions a bogous suggestion preselected

/*---------------------------------------------------------------------------------------------
 *  Copyright (c) Microsoft Corporation. All rights reserved.
 *  Licensed under the MIT License. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/

import { InstantiationType, registerSingleton } from 'vs/platform/instantiation/common/extensions';
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';

export const IExtensionHostHeapService = createDecorator<IExtensionHostHeapService>('extensionHostHeapService');

export interface IExtensionHostHeapService {

	_serviceBrand: undefined;

	registerObject(obj: object): number;
}


registerSingleton(IExtensionHostHeapService, new class implements IExtensionHostHeapService { }, InstantiationType.)

@hediet hediet added this to the On Deck milestone Feb 6, 2023
hediet added a commit that referenced this issue Apr 14, 2023
hediet added a commit that referenced this issue Apr 17, 2023
hediet added a commit that referenced this issue Apr 17, 2023
hediet added a commit that referenced this issue Apr 17, 2023
@hediet hediet modified the milestones: On Deck, April 2023 Apr 21, 2023
@jrieken jrieken added the verified Verification succeeded label Apr 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug inline-completions verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants