Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File search - navigate history with arrow keys, and fields with tabs? #17492

Closed
fabiospampinato opened this issue Dec 18, 2016 · 9 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search Search widget and operation issues suggest IntelliSense, Auto Complete

Comments

@fabiospampinato
Copy link
Contributor

Sublime gives us the ability to cycle through the previous search queries using the arrow keys, the same way as when using a terminal.

Would be cool to have this features also in VSC.

@kieferrm kieferrm added the feature-request Request for new features or functionality label Dec 19, 2016
@roblourens
Copy link
Member

This actually exists, using alt+up/down. The arrow keys alone move focus around, which I think is more commonly used.

@fabiospampinato
Copy link
Contributor Author

fabiospampinato commented Jan 6, 2017

Good to know, thanks.

It's probably more used since I guess not that many people now about those other shortcuts. I personally find myself way more often in need to cycle through the previous queries than moving up and down to the other fields.

@roblourens
Copy link
Member

I think it probably works this way because 'tab' goes to the option buttons (maybe an accessibility requirement). I personally like the current behavior but I'll leave this issue open for any other opinions on changing it so that arrow keys navigate history and tab goes through the fields.

@roblourens roblourens reopened this Jan 6, 2017
@roblourens roblourens added the search Search widget and operation issues label Jan 6, 2017
@roblourens roblourens changed the title [Request] Search history File search - navigate history with arrow keys, and fields with tabs? Jan 6, 2017
@fabiospampinato
Copy link
Contributor Author

fabiospampinato commented Jan 6, 2017

I think this way is fine, those shortcuts should probably be advertised a little more though.

If the behavior of the tab key changes then people can't toggle anymore the buttons, which assuming somebody does would make the change break things for them.

@roblourens roblourens added the suggest IntelliSense, Auto Complete label Jan 6, 2017
@alexdima alexdima removed their assignment Jan 9, 2017
@allancm
Copy link

allancm commented Mar 3, 2017

Weird I have installed version 1.10.1 and I can only move in the history of search by Alt+Up or Alt+Down in the search of the file but not in the "Find in files" or "Replace in files". I think when the feature is enabled it should be easy to know actually it's present in a combo as it is implemented in Visual Studio 2015.

@umpirsky
Copy link

umpirsky commented Jul 7, 2017

Would be cool to be able to navigate files to include the same way. Atom can.

@megatux
Copy link

megatux commented Aug 9, 2017

This feature is not complete. You can navigate through your search term history but you can't do the same with file include/exclude patterns. Should I open a new feature request?

@roblourens
Copy link
Member

That should be fixed in 1.15, actually

@roblourens
Copy link
Member

I noticed that we have #12645 tracking this

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 13, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality search Search widget and operation issues suggest IntelliSense, Auto Complete
Projects
None yet
Development

No branches or pull requests

8 participants